Starting November 9th, common-lisp.net's Gitlab instance has implemented a more open account policy, allowing anyone with a GitHub or Google account to create an account on our instance.

At the same time, the login policy has started to require 2-factor authentication (2FA).

See https://mailman.common-lisp.net/pipermail/clo-devel/2018-October/001232.html for discussion.

More cleanups, introduce a function for adjusting return values

when a function is implemented in terms of another.
parent d8ecca4b
......@@ -255,6 +255,17 @@ public final class StringFunctions {
}
};
private static LispObject
swapReturnValue(int original,
StringIndicesAndChars indicesAndChars) {
if (original < 0) {
return NIL;
}
int delta = original - indicesAndChars.start1;
int retVal = indicesAndChars.start2 + delta;
return Fixnum.getInstance(retVal);
}
// ### %string>
// Case sensitive.
private static final Primitive _STRING_GREATER_THAN = new pf__string_greater_than();
......@@ -273,12 +284,7 @@ public final class StringFunctions {
fifth, sixth,
third, fourth);
int tmp = lessThan(indicesAndChars);
if (tmp < 0) {
return NIL;
}
int delta = tmp - indicesAndChars.start1;
int retVal = indicesAndChars.start2 + delta;
return Fixnum.getInstance(retVal);
return swapReturnValue(tmp, indicesAndChars);
}
};
......@@ -346,12 +352,7 @@ public final class StringFunctions {
fifth, sixth,
third, fourth);
int tmp = lessThanOrEqual(indicesAndChars);
if (tmp < 0) {
return NIL;
}
int delta = tmp - indicesAndChars.start1;
int retVal = indicesAndChars.start2 + delta;
return Fixnum.getInstance(retVal);
return swapReturnValue(tmp, indicesAndChars);
}
};
......@@ -420,12 +421,7 @@ public final class StringFunctions {
fifth, sixth,
third, fourth);
int tmp = stringLessp(indicesAndChars);
if (tmp < 0) {
return NIL;
}
int delta = tmp - indicesAndChars.start1;
int retVal = indicesAndChars.start2 + delta;
return Fixnum.getInstance(retVal);
return swapReturnValue(tmp, indicesAndChars);
}
};
......@@ -495,12 +491,7 @@ public final class StringFunctions {
fifth, sixth,
third, fourth);
int tmp = stringNotLessp(indicesAndChars);
if (tmp < 0) {
return NIL;
}
int delta = tmp - indicesAndChars.start1;
int retVal = indicesAndChars.start2 + delta;
return Fixnum.getInstance(retVal);
return swapReturnValue(tmp, indicesAndChars);
}
};
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment