gsll merge requestshttps://gitlab.common-lisp.net/antik/gsll/-/merge_requests2016-12-26T04:38:44Zhttps://gitlab.common-lisp.net/antik/gsll/-/merge_requests/1X162016-12-26T04:38:44ZMirko VukovicX16My commits enable loading of GSL1 on MSYS2 (on Windows 10 & CCL)
I went through all the tests that were causing execution errors and either cleaned them up or tried to improve their handling.[readme-mv.pdf](/uploads/24fb0364c40a8b955101...My commits enable loading of GSL1 on MSYS2 (on Windows 10 & CCL)
I went through all the tests that were causing execution errors and either cleaned them up or tried to improve their handling.[readme-mv.pdf](/uploads/24fb0364c40a8b955101f8179f054e99/readme-mv.pdf)https://gitlab.common-lisp.net/antik/gsll/-/merge_requests/2fixed incorrect logic in rng testpdf2016-12-28T22:41:24ZMirko Vukovicfixed incorrect logic in rng testpdfThe test logic is to compare the actual and expected count in bins. This works as long as the actual and expected pdf's are properly normalized.
In the prior code this assumption failed when the upper and lower bin limits (given by *gs...The test logic is to compare the actual and expected count in bins. This works as long as the actual and expected pdf's are properly normalized.
In the prior code this assumption failed when the upper and lower bin limits (given by *gslt-lower-limit* and *gslt-upper-limit*) were such that some of the PDF was left unsampled. Under those conditions, the tests in limits-check would never pass. For some distribution functions the tests took forever to complete because upon a failure test the number of samples would be doubled (up to 50 times, leading to a 10^15 increase in the number of points).
The proposed merge fixes to code so to satisfy this assumption. I also re-factored some code and added documentation.
After the change, all the tests run in a finite amount of time and pass as well.https://gitlab.common-lisp.net/antik/gsll/-/merge_requests/3wip:X16 rng chisq test2016-12-30T14:41:34ZMirko Vukovicwip:X16 rng chisq testThe code calculates chi-squared to compare two distributions and the probability that the sampled data comes from the same distribution.
The code is not ready for merge with master, and I do not think it is absolutely essential for it t...The code calculates chi-squared to compare two distributions and the probability that the sampled data comes from the same distribution.
The code is not ready for merge with master, and I do not think it is absolutely essential for it to be part of master. If it is to be included in master, it should be improved to include more code-sharing with random-numbers/test.lisp
It is the editor-in-chief's choice whether code like this should be part of GSLL.https://gitlab.common-lisp.net/antik/gsll/-/merge_requests/4Commit 324adf11 fixes code that can lead to infinite loop when testing foreig...2017-01-03T22:01:21ZMirko VukovicCommit 324adf11 fixes code that can lead to infinite loop when testing foreign arraySee commit comment in mv branch for explanation.See commit comment in mv branch for explanation.