Commit 7eadb203 authored by Liam Healy's avatar Liam Healy

Rename #'validp from #'data-valid

For permutations and combinations, rename #'validp from #'data-valid
and return :success-failure rather than :boolean.  In fact, it returns
T or an error due to the design of the GSL functions; not clear if
this is wanted on the GSL designers' part.  Passes SBCL 64 test.
parent 12c2be7e
;; Combinations
;; Liam Healy, Sun Mar 26 2006 - 11:51
;; Time-stamp: <2008-12-31 21:10:06EST combination.lisp>
;; Time-stamp: <2009-01-11 14:23:51EST combination.lisp>
;; $Id$
(in-package :gsl)
......@@ -120,11 +120,11 @@
"A pointer to the array of elements in the combination.")
(defmfun data-valid ((combination combination))
(defmfun validp ((combination combination))
(((mpointer combination) :pointer))
:definition :method
:c-return :boolean
:c-return :success-failure
:documentation ; FDL
"Check that the combination is valid. The k
elements should lie in the range 0 to n-1, with each
;; Permutations
;; Liam Healy, Sun Mar 26 2006 - 11:51
;; Time-stamp: <2009-01-08 10:28:06EST permutation.lisp>
;; Time-stamp: <2009-01-11 14:18:42EST permutation.lisp>
;; $Id$
(in-package :gsl)
......@@ -106,15 +106,15 @@
"A pointer to the array of elements in the
permutation p.")
(defgeneric data-valid (object)
(defgeneric validp (object)
(:documentation ; FDL
"Check that the object p is valid."))
(defmfun data-valid ((permutation permutation))
(defmfun validp ((permutation permutation))
(((mpointer permutation) :pointer))
:definition :method
:c-return :boolean
:c-return :success-failure
:inputs (permutation)
:documentation ; FDL
"Check that the permutation p is valid. The n
......@@ -34,10 +34,14 @@ Fail in CCL but not in SBCL:
=== GSL questions ===
Sun Nov 9 2008:
gsl_stats_float_wmean gives erroneous answers; other weighted?
Query: What is _swap_rowcol supposed to do? What is its purpose?
gsl_blas_cdotu, gsl_blas_cdotc give nonsense results.
Any explanation for any of the modified Givens rotations such as
gsl_blas_dger rank 1 update says lengths are bad?
(from Sun Nov 9 2008)
Sun Jan 11 2009:
gsl_permutation_valid (presumably combination too) signals an error if
the permutation is invalid, rather than just returning an error code.
Is this intentional?
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment