Commit 80da2354 authored by Elias Pipping's avatar Elias Pipping

Avoid duplicate call to lisp-implementation-version

The way that lisp-version-string is written, it will fall back to
lisp-implementation-version unless a platform-specific override is
provided. Since the body of lisp-version-string uses

  (car (list #+foo exp1 exp2))

rather than

  (or #+foo exp1 exp2)

it is theoretically possible that lisp-version-string would return NIL
if that's what exp1 evaluates to, which would not also be returned by
lisp-implementation-version, which it previously would not have.

Such behaviour would qualify as a bug in lisp-version-string, though.
parent 4fbcf91f
...@@ -238,7 +238,7 @@ suitable for use as a directory name to segregate Lisp FASLs, C dynamic librarie ...@@ -238,7 +238,7 @@ suitable for use as a directory name to segregate Lisp FASLs, C dynamic librarie
#\_ #'(lambda (x) (find x " /:;&^\\|?<>(){}[]$#`'\"")) #\_ #'(lambda (x) (find x " /:;&^\\|?<>(){}[]$#`'\""))
(format nil "~(~a~@{~@[-~a~]~}~)" (format nil "~(~a~@{~@[-~a~]~}~)"
(or (implementation-type) (lisp-implementation-type)) (or (implementation-type) (lisp-implementation-type))
(or (lisp-version-string) (lisp-implementation-version)) (lisp-version-string)
(or (operating-system) (software-type)) (or (operating-system) (software-type))
(or (architecture) (machine-type)))))) (or (architecture) (machine-type))))))
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment