action.lisp 25.2 KB
Newer Older
1 2 3
;;;; -------------------------------------------------------------------------
;;;; Actions

4
(uiop/package:define-package :asdf/action
5
  (:nicknames :asdf-action)
6 7
  (:recycle :asdf/action :asdf/plan :asdf)
  (:use :uiop/common-lisp :uiop :asdf/upgrade :asdf/session :asdf/component :asdf/operation)
8
  (:import-from :asdf/operation #:check-operation-constructor)
9
  #-clisp (:unintern #:required-components #:traverse-action #:traverse-sub-actions)
10
  (:export
11
   #:action #:define-convenience-action-methods
12 13 14
   #:action-description #:format-action
   #:downward-operation #:upward-operation #:sideway-operation #:selfward-operation
   #:non-propagating-operation
15
   #:component-depends-on
16 17
   #:input-files #:output-files #:output-file #:operation-done-p
   #:action-status #:action-stamp #:action-done-p
18
   #:action-operation #:action-component #:make-action
19
   #:component-operation-time #:mark-operation-done #:compute-action-stamp
20
   #:perform #:perform-with-restarts #:retry #:accept #:*action*
21
   #:action-path #:find-action #:stamp #:done-p
22
   #:operation-definition-warning #:operation-definition-error ;; condition
23 24 25
   #:action-valid-p
   #:circular-dependency #:circular-dependency-actions
   #:call-while-visiting-action #:while-visiting-action))
26 27
(in-package :asdf/action)

28
(eval-when (#-lispworks :compile-toplevel :load-toplevel :execute) ;; LispWorks issues spurious warning
29 30 31 32 33

  (deftype action ()
    "A pair of operation and component uniquely identifies a node in the dependency graph
of steps to be performed while building a system."
    '(cons operation component))
34 35

  (deftype operation-designator ()
36 37
    "An operation designates itself. NIL designates a context-dependent current operation,
and a class-name or class designates the canonical instance of the designated class."
38
    '(or operation null symbol class)))
39

40 41 42 43 44 45 46 47 48
;;; these are pseudo accessors -- let us abstract away the CONS cell representation of plan
;;; actions.
(with-upgradability ()
  (defun make-action (operation component)
    (cons operation component))
  (defun action-operation (action)
    (car action))
  (defun action-component (action)
    (cdr action)))
49

50
;;;; Reified representation for storage or debugging. Note: an action is identified by its class.
51 52
(with-upgradability ()
  (defun action-path (action)
53
    "A readable data structure that identifies the action."
54 55 56
    (let ((o (action-operation action))
          (c (action-component action)))
      (cons (type-of o) (component-find-path c))))
57
  (defun find-action (path)
58
    "Reconstitute an action from its action-path"
59
    (destructuring-bind (o . c) path (make-action (make-operation o) (find-component () c)))))
60 61

;;;; Convenience methods
62
(with-upgradability ()
63 64 65 66 67 68 69 70
  ;; A macro that defines convenience methods for a generic function (gf) that
  ;; dispatches on operation and component.  The convenience methods allow users
  ;; to call the gf with operation and/or component designators, that the
  ;; methods will resolve into actual operation and component objects, so that
  ;; the users can interact using readable designators, but developers only have
  ;; to write methods that handle operation and component objects.
  ;; FUNCTION is the generic function name
  ;; FORMALS is its list of arguments, which must include OPERATION and COMPONENT.
71 72
  ;; IF-NO-OPERATION is a form (defaults to NIL) describing what to do if no operation is found.
  ;; IF-NO-COMPONENT is a form (defaults to NIL) describing what to do if no component is found.
73
  (defmacro define-convenience-action-methods
74
      (function formals &key if-no-operation if-no-component)
75 76
    (let* ((rest (gensym "REST"))
           (found (gensym "FOUND"))
77 78 79
           (keyp (equal (last formals) '(&key)))
           (formals-no-key (if keyp (butlast formals) formals))
           (len (length formals-no-key))
80 81 82 83 84 85
           (operation 'operation)
           (component 'component)
           (opix (position operation formals))
           (coix (position component formals))
           (prefix (subseq formals 0 opix))
           (suffix (subseq formals (1+ coix) len))
86
           (more-args (when keyp `(&rest ,rest &key &allow-other-keys))))
87
      (assert (and (integerp opix) (integerp coix) (= coix (1+ opix))))
88 89
      (flet ((next-method (o c)
               (if keyp
90 91
                   `(apply ',function ,@prefix ,o ,c ,@suffix ,rest)
                   `(,function ,@prefix ,o ,c ,@suffix))))
92
        `(progn
93
           (defmethod ,function (,@prefix (,operation string) ,component ,@suffix ,@more-args)
94
             (declare (notinline ,function))
95 96 97
             (let ((,component (find-component () ,component))) ;; do it first, for defsystem-depends-on
               ,(next-method `(safe-read-from-string ,operation :package :asdf/interface) component)))
           (defmethod ,function (,@prefix (,operation symbol) ,component ,@suffix ,@more-args)
98
             (declare (notinline ,function))
99 100
             (if ,operation
                 ,(next-method
101
                   `(make-operation ,operation)
102 103
                   `(or (find-component () ,component) ,if-no-component))
                 ,if-no-operation))
104
           (defmethod ,function (,@prefix (,operation operation) ,component ,@suffix ,@more-args)
105
             (declare (notinline ,function))
106 107
             (if (typep ,component 'component)
                 (error "No defined method for ~S on ~/asdf-action:format-action/"
108
                        ',function (make-action ,operation ,component))
109 110 111
                 (if-let (,found (find-component () ,component))
                    ,(next-method operation found)
                    ,if-no-component))))))))
112

113 114

;;;; self-description
115 116 117
(with-upgradability ()
  (defgeneric action-description (operation component)
    (:documentation "returns a phrase that describes performing this operation
118 119
on this component, e.g. \"loading /a/b/c\".
You can put together sentences using this phrase."))
120 121
  (defmethod action-description (operation component)
    (format nil (compatfmt "~@<~A on ~A~@:>")
122
            operation component))
123

124
  (defun format-action (stream action &optional colon-p at-sign-p)
125 126
    "FORMAT helper to display an action's action-description.
Use it in FORMAT control strings as ~/asdf-action:format-action/"
127 128 129
    (assert (null colon-p)) (assert (null at-sign-p))
    (destructuring-bind (operation . component) action
      (princ (action-description operation component) stream))))
130 131 132


;;;; Dependencies
133
(with-upgradability ()
134
  (defgeneric component-depends-on (operation component) ;; ASDF4: rename to component-dependencies
135 136
    (:documentation
     "Returns a list of dependencies needed by the component to perform
137 138
    the operation.  A dependency has one of the following forms:

139 140 141 142 143
      (<operation> <component>*), where <operation> is an operation designator
        with respect to FIND-OPERATION in the context of the OPERATION argument,
        and each <component> is a component designator with respect to
        FIND-COMPONENT in the context of the COMPONENT argument,
        and means that the component depends on
144 145 146 147
        <operation> having been performed on each <component>;

        [Note: an <operation> is an operation designator -- it can be either an
        operation name or an operation object.  Similarly, a <component> may be
148 149
        a component name or a component object.  Also note that, the degenerate
        case of (<operation>) is a no-op.]
150

151
    Methods specialized on subclasses of existing component types
152
    should usually append the results of CALL-NEXT-METHOD to the list."))
153
  (define-convenience-action-methods component-depends-on (operation component))
154 155 156

  (defmethod component-depends-on :around ((o operation) (c component))
    (do-asdf-cache `(component-depends-on ,o ,c)
157
      (call-next-method))))
158 159


160 161
;;;; upward-operation, downward-operation, sideway-operation, selfward-operation
;; These together handle actions that propagate along the component hierarchy or operation universe.
162 163 164
(with-upgradability ()
  (defclass downward-operation (operation)
    ((downward-operation
165
      :initform nil :reader downward-operation
166
      :type operation-designator :allocation :class))
167 168 169 170 171 172
    (:documentation "A DOWNWARD-OPERATION's dependencies propagate down the component hierarchy.
I.e., if O is a DOWNWARD-OPERATION and its DOWNWARD-OPERATION slot designates operation D, then
the action (O . M) of O on module M will depends on each of (D . C) for each child C of module M.
The default value for slot DOWNWARD-OPERATION is NIL, which designates the operation O itself.
E.g. in order for a MODULE to be loaded with LOAD-OP (resp. compiled with COMPILE-OP), all the
children of the MODULE must have been loaded with LOAD-OP (resp. compiled with COMPILE-OP."))
173 174
  (defun downward-operation-depends-on (o c)
    `((,(or (downward-operation o) o) ,@(component-children c))))
175
  (defmethod component-depends-on ((o downward-operation) (c parent-component))
176
    `(,@(downward-operation-depends-on o c) ,@(call-next-method)))
177

178 179
  (defclass upward-operation (operation)
    ((upward-operation
180
      :initform nil :reader upward-operation
181
      :type operation-designator :allocation :class))
182 183 184 185 186 187
    (:documentation "An UPWARD-OPERATION has dependencies that propagate up the component hierarchy.
I.e., if O is an instance of UPWARD-OPERATION, and its UPWARD-OPERATION slot designates operation U,
then the action (O . C) of O on a component C that has the parent P will depends on (U . P).
The default value for slot UPWARD-OPERATION is NIL, which designates the operation O itself.
E.g. in order for a COMPONENT to be prepared for loading or compiling with PREPARE-OP, its PARENT
must first be prepared for loading or compiling with PREPARE-OP."))
188 189
  ;; For backward-compatibility reasons, a system inherits from module and is a child-component
  ;; so we must guard against this case. ASDF4: remove that.
190 191
  (defun upward-operation-depends-on (o c)
    (if-let (p (component-parent c)) `((,(or (upward-operation o) o) ,p))))
192
  (defmethod component-depends-on ((o upward-operation) (c child-component))
193
    `(,@(upward-operation-depends-on o c) ,@(call-next-method)))
194

195 196
  (defclass sideway-operation (operation)
    ((sideway-operation
197
      :initform nil :reader sideway-operation
198
      :type operation-designator :allocation :class))
199 200 201 202 203 204
    (:documentation "A SIDEWAY-OPERATION has dependencies that propagate \"sideway\" to siblings
that a component depends on. I.e. if O is a SIDEWAY-OPERATION, and its SIDEWAY-OPERATION slot
designates operation S (where NIL designates O itself), then the action (O . C) of O on component C
depends on each of (S . D) where D is a declared dependency of C.
E.g. in order for a COMPONENT to be prepared for loading or compiling with PREPARE-OP,
each of its declared dependencies must first be loaded as by LOAD-OP."))
205
  (defun sideway-operation-depends-on (o c)
206
    `((,(or (sideway-operation o) o) ,@(component-sideway-dependencies c))))
207 208
  (defmethod component-depends-on ((o sideway-operation) (c component))
    `(,@(sideway-operation-depends-on o c) ,@(call-next-method)))
209

210 211
  (defclass selfward-operation (operation)
    ((selfward-operation
212
      ;; NB: no :initform -- if an operation depends on others, it must explicitly specify which
213
      :type (or operation-designator list) :reader selfward-operation :allocation :class))
214
    (:documentation "A SELFWARD-OPERATION depends on another operation on the same component.
215 216
I.e., if O is a SELFWARD-OPERATION, and its SELFWARD-OPERATION designates a list of operations L,
then the action (O . C) of O on component C depends on each (S . C) for S in L.
217
E.g. before a component may be loaded by LOAD-OP, it must have been compiled by COMPILE-OP.
218 219
A operation-designator designates a singleton list of the designated operation;
a list of operation-designators designates the list of designated operations;
220 221 222
NIL is not a valid operation designator in that context.  Note that any dependency
ordering between the operations in a list of SELFWARD-OPERATION should be specified separately
in the respective operation's COMPONENT-DEPENDS-ON methods so that they be scheduled properly."))
223 224
  (defun selfward-operation-depends-on (o c)
    (loop :for op :in (ensure-list (selfward-operation o)) :collect `(,op ,c)))
225
  (defmethod component-depends-on ((o selfward-operation) (c component))
226
    `(,@(selfward-operation-depends-on o c) ,@(call-next-method)))
227 228 229

  (defclass non-propagating-operation (operation)
    ()
230
    (:documentation "A NON-PROPAGATING-OPERATION is an operation that propagates
231 232 233 234 235 236 237 238
no dependencies whatsoever.  It is supplied in order that the programmer be able
to specify that s/he is intentionally specifying an operation which invokes no
dependencies.")))


;;;---------------------------------------------------------------------------
;;; Help programmers catch obsolete OPERATION subclasses
;;;---------------------------------------------------------------------------
239 240 241 242 243 244 245 246 247 248
(with-upgradability ()
  (define-condition operation-definition-warning (simple-warning)
    ()
    (:documentation "Warning condition related to definition of obsolete OPERATION objects."))

  (define-condition operation-definition-error (simple-error)
    ()
    (:documentation "Error condition related to definition of incorrect OPERATION objects."))

  (defmethod initialize-instance :before ((o operation) &key)
249
    (check-operation-constructor)
250
    (unless (typep o '(or downward-operation upward-operation sideway-operation
251
                          selfward-operation non-propagating-operation))
252 253 254 255 256 257 258 259 260 261 262 263 264 265 266
      (warn 'operation-definition-warning
            :format-control
            "No dependency propagating scheme specified for operation class ~S.
The class needs to be updated for ASDF 3.1 and specify appropriate propagation mixins."
            :format-arguments (list (type-of o)))))

  (defmethod initialize-instance :before ((o non-propagating-operation) &key)
    (when (typep o '(or downward-operation upward-operation sideway-operation selfward-operation))
      (error 'operation-definition-error
             :format-control
             "Inconsistent class: ~S
  NON-PROPAGATING-OPERATION is incompatible with propagating operation classes as superclasses."
             :format-arguments
             (list (type-of o)))))

Francois-Rene Rideau's avatar
Francois-Rene Rideau committed
267 268
  (defun backward-compatible-depends-on (o c)
    "DEPRECATED: all subclasses of OPERATION used in ASDF should inherit from one of
269 270 271
 DOWNWARD-OPERATION UPWARD-OPERATION SIDEWAY-OPERATION SELFWARD-OPERATION NON-PROPAGATING-OPERATION.
 The function BACKWARD-COMPATIBLE-DEPENDS-ON temporarily provides ASDF2 behaviour for those that
 don't. In the future this functionality will be removed, and the default will be no propagation."
Francois-Rene Rideau's avatar
Francois-Rene Rideau committed
272 273 274 275 276
    (uiop/version::notify-deprecated-function
     (version-deprecation *asdf-version* :style-warning "3.2")
     'backward-compatible-depends-on)
    `(,@(sideway-operation-depends-on o c)
      ,@(when (typep c 'parent-component) (downward-operation-depends-on o c))))
277

278 279 280
  (defmethod component-depends-on ((o operation) (c component))
    `(;; Normal behavior, to allow user-specified in-order-to dependencies
      ,@(cdr (assoc (type-of o) (component-in-order-to c)))
281 282 283 284 285
        ;; For backward-compatibility with ASDF2, any operation that doesn't specify propagation
        ;; or non-propagation through an appropriate mixin will be downward and sideway.
        ,@(unless (typep o '(or downward-operation upward-operation sideway-operation
                             selfward-operation non-propagating-operation))
            (backward-compatible-depends-on o c))))
286 287 288 289

  (defmethod downward-operation ((o operation)) nil)
  (defmethod sideway-operation ((o operation)) nil))

290 291 292 293

;;;---------------------------------------------------------------------------
;;; End of OPERATION class checking
;;;---------------------------------------------------------------------------
294 295 296


;;;; Inputs, Outputs, and invisible dependencies
297
(with-upgradability ()
298
  (defgeneric output-files (operation component)
299
    (:documentation "Methods for this function return two values: a list of output files
300 301 302
corresponding to this action, and a boolean indicating if they have already been subjected
to relevant output translations and should not be further translated.

303
Methods on PERFORM *must* call this function to determine where their outputs are to be located.
304 305
They may rely on the order of the files to discriminate between outputs.
"))
306
  (defgeneric input-files (operation component)
307 308
    (:documentation "A list of input files corresponding to this action.

309
Methods on PERFORM *must* call this function to determine where their inputs are located.
310 311
They may rely on the order of the files to discriminate between inputs.
"))
312
  (defgeneric operation-done-p (operation component)
313
    (:documentation "Returns a boolean which is NIL if the action must be performed (again)."))
314 315 316 317 318 319 320
  (define-convenience-action-methods output-files (operation component))
  (define-convenience-action-methods input-files (operation component))
  (define-convenience-action-methods operation-done-p (operation component))

  (defmethod operation-done-p ((o operation) (c component))
    t)

321
  ;; Translate output files, unless asked not to. Memoize the result.
322
  (defmethod output-files :around ((operation t) (component t))
323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345
    (do-asdf-cache `(output-files ,operation ,component)
      (values
       (multiple-value-bind (pathnames fixedp) (call-next-method)
         ;; 1- Make sure we have absolute pathnames
         (let* ((directory (pathname-directory-pathname
                            (component-pathname (find-component () component))))
                (absolute-pathnames
                  (loop
                    :for pathname :in pathnames
                    :collect (ensure-absolute-pathname pathname directory))))
           ;; 2- Translate those pathnames as required
           (if fixedp
               absolute-pathnames
               (mapcar *output-translation-function* absolute-pathnames))))
       t)))
  (defmethod output-files ((o operation) (c component))
    nil)
  (defun output-file (operation component)
    "The unique output file of performing OPERATION on COMPONENT"
    (let ((files (output-files operation component)))
      (assert (length=n-p files 1))
      (first files)))

346
  ;; Memoize input files.
347 348 349 350
  (defmethod input-files :around (operation component)
    (do-asdf-cache `(input-files ,operation ,component)
      (call-next-method)))

351
  ;; By default an action has no input-files.
352
  (defmethod input-files ((o operation) (c component))
353 354
    nil)

355 356 357 358
  ;; An action with a selfward-operation by default gets its input-files from the output-files of
  ;; the actions using selfward-operations it depends on (and the same component),
  ;; or if there are none, on the component-pathname of the component if it's a file
  ;; -- and then on the results of the next-method.
359 360 361 362 363 364
  (defmethod input-files ((o selfward-operation) (c component))
    `(,@(or (loop :for dep-o :in (ensure-list (selfward-operation o))
                  :append (or (output-files dep-o c) (input-files dep-o c)))
            (if-let ((pathname (component-pathname c)))
              (and (file-pathname-p pathname) (list pathname))))
      ,@(call-next-method))))
365 366 367


;;;; Done performing
368
(with-upgradability ()
369 370 371 372 373
  ;; ASDF4: hide it behind plan-action-stamp
  (defgeneric component-operation-time (operation component)
    (:documentation "Return the timestamp for when an action was last performed"))
  (defgeneric (setf component-operation-time) (time operation component)
    (:documentation "Update the timestamp for when an action was last performed"))
374
  (define-convenience-action-methods component-operation-time (operation component))
375

376 377 378 379 380 381
  ;; ASDF4: hide it behind (setf plan-action-stamp)
  (defgeneric mark-operation-done (operation component)
    (:documentation "Mark a action as having been just done.

Updates the action's COMPONENT-OPERATION-TIME to match the COMPUTE-ACTION-STAMP
using the JUST-DONE flag."))
382 383
  (defgeneric compute-action-stamp (plan operation component &key just-done)
    (:documentation "Has this action been successfully done already,
384
and at what known timestamp has it been done at or will it be done at?
385 386 387 388
* PLAN is a plan object modelling future effects of actions,
  or NIL to denote what actually happened.
* OPERATION and COMPONENT denote the action.
Takes keyword JUST-DONE:
389 390 391
* JUST-DONE is a boolean that is true if the action was just successfully performed,
  at which point we want compute the actual stamp and warn if files are missing;
  otherwise we are making plans, anticipating the effects of the action.
392 393
Returns two values:
* a STAMP saying when it was done or will be done,
394
  or T if the action involves files that need to be recomputed.
395 396 397
* a boolean DONE-P that indicates whether the action has actually been done,
  and both its output-files and its in-image side-effects are up to date."))

398 399 400 401
  (defclass action-status ()
    ((stamp
      :initarg :stamp :reader action-stamp
      :documentation "STAMP associated with the ACTION if it has been completed already
402
in some previous image, or T if it needs to be done.")
403 404 405 406
     (done-p
      :initarg :done-p :reader action-done-p
      :documentation "a boolean, true iff the action was already done (before any planned action)."))
    (:documentation "Status of an action"))
407

408 409 410 411
  (defmethod print-object ((status action-status) stream)
    (print-unreadable-object (status stream :type t)
      (with-slots (stamp done-p) status
        (format stream "~@{~S~^ ~}" :stamp stamp :done-p done-p))))
412

413
  (defmethod component-operation-time ((o operation) (c component))
414
    (gethash o (component-operation-times c)))
415

416
  (defmethod (setf component-operation-time) (stamp (o operation) (c component))
417
    (setf (gethash o (component-operation-times c)) stamp))
418

419
  (defmethod mark-operation-done ((o operation) (c component))
420
    (setf (component-operation-time o c) (compute-action-stamp nil o c :just-done t))))
421 422 423


;;;; Perform
424
(with-upgradability ()
425
  (defgeneric perform (operation component)
426
    (:documentation "PERFORM an action, consuming its input-files and building its output-files"))
427 428
  (define-convenience-action-methods perform (operation component))

429 430 431 432 433
  (defvar *action* nil
    "Action being performed")
  (defmethod perform :around ((o operation) (c component))
    (let ((*action* (cons o c)))
      (call-next-method)))
434 435 436 437 438 439 440
  (defmethod perform :before ((o operation) (c component))
    (ensure-all-directories-exist (output-files o c)))
  (defmethod perform :after ((o operation) (c component))
    (mark-operation-done o c))
  (defmethod perform ((o operation) (c parent-component))
    nil)
  (defmethod perform ((o operation) (c source-file))
441 442 443 444 445
    ;; For backward compatibility, don't error on operations that don't specify propagation.
    (when (typep o '(or downward-operation upward-operation sideway-operation
                     selfward-operation non-propagating-operation))
      (sysdef-error
       (compatfmt "~@<Required method ~S not implemented for ~/asdf-action:format-action/~@:>")
446
       'perform (make-action o c))))
447

448 449 450
  ;; The restarts of the perform-with-restarts variant matter in an interactive context.
  ;; The retry strategies of p-w-r itself, and/or the background workers of a multiprocess build
  ;; may call perform directly rather than call p-w-r.
451
  (defgeneric perform-with-restarts (operation component)
452
    (:documentation "PERFORM an action in a context where suitable restarts are in place."))
453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470
  (defmethod perform-with-restarts (operation component)
    (perform operation component))
  (defmethod perform-with-restarts :around (operation component)
    (loop
      (restart-case
          (return (call-next-method))
        (retry ()
          :report
          (lambda (s)
            (format s (compatfmt "~@<Retry ~A.~@:>")
                    (action-description operation component))))
        (accept ()
          :report
          (lambda (s)
            (format s (compatfmt "~@<Continue, treating ~A as having been successful.~@:>")
                    (action-description operation component)))
          (mark-operation-done operation component)
          (return))))))
471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507


;;;; Detection of circular dependencies
(with-upgradability ()
  (defun (action-valid-p) (operation component)
    "Is this action valid to include amongst dependencies?"
    ;; If either the operation or component was resolved to nil, the action is invalid.
    ;; :if-feature will invalidate actions on components for which the features don't apply.
    (and operation component
         (if-let (it (component-if-feature component)) (featurep it) t)))

  (define-condition circular-dependency (system-definition-error)
    ((actions :initarg :actions :reader circular-dependency-actions))
    (:report (lambda (c s)
               (format s (compatfmt "~@<Circular dependency: ~3i~_~S~@:>")
                       (circular-dependency-actions c)))))

  (defun call-while-visiting-action (operation component fun)
    "Detect circular dependencies"
    (when (action-valid-p operation component)
      (with-accessors ((action-set visiting-action-set)
                       (action-list visiting-action-list)) *asdf-session*
        (let ((action (cons operation component)))
          (when (gethash action action-set)
            (error 'circular-dependency :actions
                   (member action (reverse action-list) :test 'equal)))
          (setf (gethash action action-set) t)
          (push action action-list)
          (unwind-protect
               (funcall fun)
            (pop action-list)
            (setf (gethash action action-set) nil))))))

  ;; Syntactic sugar for call-while-visiting-action
  (defmacro while-visiting-action ((o c) &body body)
    `(call-while-visiting-action ,o ,c #'(lambda () ,@body))))