Commit 817e6ffd authored by Francois-Rene Rideau's avatar Francois-Rene Rideau

Yet another cleanup after feedback from Robert

parent 14eb09d3
......@@ -4,8 +4,9 @@
** Already, swank-asdf doesn't support anything older than 2.014.6
(as provided by the first 2011 iteration of Quicklisp), and
I (fare) am pushing for swank-asdf to not support anything older
than 3.0 (since no maintained implementation has anything older,
with the LispWorks 7.0 release being last to upgrade, in May 2015).
than 3.1.2 (since no maintained implementation has anything older,
with the LispWorks 7.0 release being last to upgrade, in May 2015;
or CLISP hg in May 2016, though it hasn't been released since 2010).
** Maybe remove old versions from upgrade tests; or maybe not:
if we support old versions in any way,
it should be for upgrade only, and "punt" is acceptable.
......@@ -13,6 +14,8 @@
Clear all the code in the header, and/or
move a few elements to asdf/upgrade.
** Upgrade tests might be split in two test sets: short and long.
** Make tests stateless and/or make any modifications private,
so that they can be run in parallel.
* Moving toward cross-compilation (ASDF 3.2? 4?)
This would allow to get most of the benefits of XCVB
......
......@@ -54,7 +54,7 @@ and support for them may be discontinued at any moment.
;; A memoizing way of creating instances of operation.
(defun make-operation (operation-class &rest initargs)
"This function creates and memoizes an instance of OPERATION-CLASS.
All operations MUST created through this function.
All operation instances MUST be created through this function.
Use of INITARGS is for backward compatibility and may be discontinued at any time."
(let ((class (coerce-class operation-class
......
......@@ -22,6 +22,8 @@
))
(in-package :asdf/output-translations)
;; (setf output-translations) at some point used to be a macro for the sake of
;; obsolete versions of GCL. Make sure that macro doesn't come to haunt us.
(when-upgrading () (undefine-function '(setf output-translations)))
(with-upgradability ()
......
......@@ -37,13 +37,15 @@
(defclass plan-traversal (plan)
(;; The system for which the plan is computed
(system :initform nil :initarg :system :accessor plan-system)
;; Tables of systems specified via :force and :force-not arguments
;; Table of systems specified via :force arguments
(forced :initform nil :initarg :force :accessor plan-forced)
;; Table of systems specified via :force-not argument (and/or immutable)
(forced-not :initform nil :initarg :force-not :accessor plan-forced-not)
;; Counts of total actions in plan, actions that need to be performed,
;; actions that need to be performed are those that have a non-empty list of output-files.
;; Counts of total actions in plan
(total-action-count :initform 0 :accessor plan-total-action-count)
;; Count of actions that need to be performed
(planned-action-count :initform 0 :accessor plan-planned-action-count)
;; Count of actions that need to be performed that have a non-empty list of output-files.
(planned-output-action-count :initform 0 :accessor plan-planned-output-action-count)
;; Table that to actions already visited while walking the dependencies associates status
(visited-actions :initform (make-hash-table :test 'equal) :accessor plan-visited-actions)
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment