Commit f0cf7668 authored by Robert Goldman's avatar Robert Goldman

Add more verbose output.

parent 48fd5d11
......@@ -135,7 +135,8 @@
(setf error-status 'general)
(setf error-description (format nil "~a" c))
(return-from test-case))))
,@body))
,@body)
(format t "~&~T...completed successfully.~%"))
(case error-status
(failed (incf *number-of-failed-tests*))
(unsupported (report-result "" "NOT SUPPORTED"))
......
  • (assuming this is meant as a permanent change and you didn't just temporarily push it for your current multi-machine testing): I'd prefer to not merge this change.

    • It's superfluous: The first thing the next test will do is print its name. So the fact that the next line prints its name means that the previous test completed.
    • It adds even more noise to a test suite which is already too verbose for my taste.
  • (Once all subtests have run, a summary is printed)

  • If you insist (which I hope you don't) I suggest at least the following change to bring the output in line with the rest:

    --- a/test/test-run-program-unix-internal.script
    +++ b/test/test-run-program-unix-internal.script
    @@ -136,7 +136,7 @@
                                         (setf error-description (format nil "~a" c))
                                         (return-from test-case))))
                       ,@body)
    -                (format t "~&~T...completed successfully.~%"))
    +                (report-result "" "PASSED"))
                   (case error-status
                     (failed (incf *number-of-failed-tests*))
                     (unsupported (report-result "" "NOT SUPPORTED"))
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment