1. 23 May, 2017 11 commits
    • Francois-Rene Rideau's avatar
      plan: implement phase level escalation · f62e6fe0
      Francois-Rene Rideau authored
      Track at which level of nested calls to OPERATE a not-done action is needed;
      if it is needed at a higher level than previously traversed, then traverse again
      to schedule it (and its transitive dependencies) to be done in the higher level.
      This fixes cases, such as in (test-system "cl-protobufs-tests"), where a library
      was already marked as needed at a low level of OPERATE, but if actually needed
      at higher level due to a defsystem-depends-on, and was previously not loaded
      early enough (after this plan refactoring).
      f62e6fe0
    • Francois-Rene Rideau's avatar
      Correctly track status of actions across phases · 40b86923
      Francois-Rene Rideau authored
      Do not perform an action twice in a session. Introduce three status bits
      that every action has in a given session, in addition to the stamp:
      KEEP-P (from previous session), DONE-P (and up-to-date, in this image),
      NEED-P (needed in this image as part of this session).
      
      BACKWARD INCOMPATIBILITY: Invert the meaning of NIL and T for STAMP,
      so that NIL means out-of-date. This makes our code conceptually nicer,
      and no one in Quicklisp uses our stamps, anyway. Still, beware.
      40b86923
    • Francois-Rene Rideau's avatar
      Replace *defined-systems* by *registered-systems* · a5345448
      Francois-Rene Rideau authored
      Use a simple table *registered-systems* mapping name to system,
      and remember timestamps in the COMPONENT-OPERATION-TIME for DEFINE-OP,
      instead of the original *defined-systems* table mapping name to
      cons of timestamp and system.
      a5345448
    • Francois-Rene Rideau's avatar
      Separate forcing from plan · fe835596
      Francois-Rene Rideau authored
      Move forcing into its own file.
      Include forcing, not plan, among session slots.
      Share a toplevel forcing for all performable plans.
      Have REQUIRE use load-system, not require-system,
      so as not to conflict with session forcing options.
      Don't call with-asdf-session outside the test scripts themselves.
      Cleanup a few scripts accordingly, and beyond.
      fe835596
    • Francois-Rene Rideau's avatar
      Move flag for asdf upgrade from operate to session. · 0796586f
      Francois-Rene Rideau authored
      This should notably prevent recording of a circular dependency of asdf on asdf.
      0796586f
    • Francois-Rene Rideau's avatar
      More refactoring of plan · fbe6d4f5
      Francois-Rene Rideau authored
      Move action-status wholly to plan, merge it with planned-action-status.
      Add a performable-p flag to plans.
      Simplify sequential-plan and required-components; have them use a separate
      function collect-action-dependencies for traversing the graph.
      Add a function action-up-to-date-p to check whether an action is up-to-date,
      without adding it to the plan if it wasn't.
      fbe6d4f5
    • Francois-Rene Rideau's avatar
      Include DEFINE-OP in mark-component-preloaded · dd29916b
      Francois-Rene Rideau authored
      Move it to asdf/find-system.
      dd29916b
    • Francois-Rene Rideau's avatar
      Refactor load-asd to perform a define-op · 7f92cab9
      Francois-Rene Rideau authored
      Split asdf/system-registry away from asdf/find-system: the former defines
      the internal *defined-systems* table and the search mechanism, whereas
      the latter keeps the find-system methods, but also defines a new
      define-op operation, on load-asd will call operate.
      
      Reorder dependencies accordingly.
      
      Have forcing come from the plan, so as to not force again actions from
      dependencies that were already performed in a subcall to operate.
      
      Accept asdf.asd from the same version, so asdf.asd doesn't get removed
      at the very next call to operate (which may now come implicitly
      at the least provocation).
      7f92cab9
    • Francois-Rene Rideau's avatar
      Move node visit information from plan to session · aba8811b
      Francois-Rene Rideau authored
      Significantly refactor plan internals.
      
      Move visited-actions, visiting-action-set, visiting-action-list,
      total-action-count, planned-action-count, planned-output-action-count
      from plan to session (remove the plan- prefix to accessors).
      
      Move sysdef-error from component to session.
      
      Remove plan as a parameter of action-valid-p (made simple defun)
      and while-visiting-action (both moved to action), but also
      map-direct-dependencies, reduce-direct-dependencies, direct-dependencies.
      
      Rename *default-plan-class* to *plan-class*,
      plan-record-dependency to record-dependency,
      plan-action-status to action-status
      plan-forced (accessor) to forced, plan-forced-not (accessor) to forced-not.
      
      Introduce define-op, and visit a suitable action while loading an asd file.
      Accumulate inner operate dependencies in a slot definition-dependencies of
      a registered system or a newly registered undefined-system.
      
      Introduce reset-session or reset-session-visited in various tests,
      so operations aren't considered as layered atop each other, but
      as restarting from a fresh planning session.
      
      Use with-asdf-session in required-components, make-plan.
      
      Stop using node-for, use cons directly, now that operations are safe.
      
      Export format-action from action.
      
      Move some conditions and generic functions around and reorder dependencies.
      aba8811b
    • Francois-Rene Rideau's avatar
      Introduce an *asdf-session* that may contain more than a cache. · a925eda1
      Francois-Rene Rideau authored
      Replace with-asdf-cache with with-asdf-session.
      Introduce *asdf-session-class* to hold the class of the session.
      Introduce caching-cache, currently the only session class,
      that only contains a cache, for now.
      a925eda1
    • Francois-Rene Rideau's avatar
      Rename asdf/cache to asdf/session · c1a125bb
      Francois-Rene Rideau authored
      c1a125bb
  2. 17 Feb, 2017 2 commits
  3. 12 Jan, 2017 1 commit
  4. 26 Nov, 2016 1 commit
    • Francois-Rene Rideau's avatar
      Get fully rid of operation initargs · 6bb7aa6b
      Francois-Rene Rideau authored
      ASDF never supported operation initargs, and its component-operation-times
      always assumed that two operations of the same class were equivalent.
      Make it explicitly so and enforce it.
      
      Do NOT pass keys from operate to make-instance operation.
      Catch any attempt to create an operation with initargs and raise an error.
      Make sure no operation class has any slot that isn't :allocation :class
      (with some MOP magic we could do it in at class definition time,
      but that's not portable enough and we don't want to reimplement closer-mop
      or depend on it.)
      
      This is a preliminary to allowing CONS instead of NODE-FOR to identify actions,
      whether or not we want to allow some form of initargs in the future.
      
      Remove unused COMPILE-OP-FLAGS and COMPILE-OP-PROCLAMATIONS.
      Remove MAKE-BUILD that depended on the unsupported operation initargs.
      Use PROGRAM-OP on a PROGRAM-SYSTEM instead.
      Remove the confusingly misnamed and not-so-useful BUILD-SYSTEM function;
      it can be done better in userland.
      6bb7aa6b
  5. 16 Oct, 2016 1 commit
    • Francois-Rene Rideau's avatar
      Stop fmakunbound'ing defgeneric's past the upgrade trigger · 8e0ec0e9
      Francois-Rene Rideau authored
      If we fmakunbound a defgeneric, we lose any user-defined method on the function
      and must therefore reload any and every system that might have defined methods
      on it. We must therefore not fmakunbound past the forward compatibility upgrade
      trigger, only before. Adjust our code accordingly. Conservative bounds are used
      in *oldest-forward-compatible-asdf-version* and redefined-functions that should
      probably be refined after some inspection of old versions.
      
      This is a response to https://bugs.launchpad.net/asdf/+bug/1631771
      8e0ec0e9
  6. 25 Sep, 2016 4 commits
    • Francois-Rene Rideau's avatar
    • Francois-Rene Rideau's avatar
      Use make-operation to create operations · cba5261e
      Francois-Rene Rideau authored
      Stop using make-instance directly in a few places.
      Use our convenience methods in other places.
      cba5261e
    • Francois-Rene Rideau's avatar
      Fix the upgrade hooks · 9b431ca3
      Francois-Rene Rideau authored
      The order in which the upgrade fixups were called wasn't very robust.
      We need to first get a list of systems being defined, then
      clear defined systems (but not asdf, and *neither uiop* that asdf depends on),
      then upgrade the configuration, and *finally* reload any of the systems being
      defined (including their defsystem-depends-on dependencies!),
      which means this all has to be coordinated within the same function.
      9b431ca3
    • Francois-Rene Rideau's avatar
      Remove *post-upgrade-restart-hook* · 3dd1f67d
      Francois-Rene Rideau authored
      p-u-r-h was never called! Two functions were registered.
      Register them with *post-upgrade-cleanup-hook* instead.
      The hook was introduced with pre-release 2.27,
      possibly with the intent to be called by the main operate :around method
      when an asdf build is restarted in the middle. But that never happened.
      3dd1f67d
  7. 20 Sep, 2016 1 commit
  8. 17 Sep, 2016 1 commit
  9. 16 Sep, 2016 2 commits
  10. 15 Sep, 2016 1 commit
  11. 14 Sep, 2016 2 commits
    • Francois-Rene Rideau's avatar
      Fix component-loaded-p to not load asd files · 7f6e4fac
      Francois-Rene Rideau authored
      Add find-component keyword argument registered to not load asd files.
      Use it in component-loaded-p so we query what's registered but don't load asds.
      
      Many thanks to Daniel Kochmanski for identifying and helping solve the problem.
      7f6e4fac
    • Francois-Rene Rideau's avatar
      Eagerly register preloaded systems · d33ab0bc
      Francois-Rene Rideau authored
      Change clear-system accordingly, and simplify how we handle immutable systems.
      Add or improve documentation for several of the functions involved.
      
      Also stop advertising asdf::*immutable-systems*;
      instead promote asdf:register-immutable-system.
      
      This is a preliminary to fixing component-loaded-p for preloaded systems.
      d33ab0bc
  12. 13 Sep, 2016 1 commit
    • Francois-Rene Rideau's avatar
      Refactoring: introduce the function REGISTERED-SYSTEM · 7b7b9f0c
      Francois-Rene Rideau authored
      Introduce the function REGISTERED-SYSTEM to abstract over finding a registered
      system by name, without having to take the CDR of the pair with timestamp.
      
      Also, add or improve docstrings for several functions.
      
      This refactoring should not modify any semantics,
      except for introducing this new function.
      7b7b9f0c
  13. 12 Sep, 2016 1 commit
  14. 11 Sep, 2016 1 commit
  15. 01 Aug, 2016 1 commit
  16. 24 Jul, 2016 1 commit
  17. 28 Nov, 2015 1 commit
  18. 29 Jun, 2015 1 commit
  19. 11 Aug, 2014 1 commit
  20. 20 Jun, 2014 1 commit
    • Francois-Rene Rideau's avatar
      Fix an ASDF bootstrap bug reported by MKCL's JCB. · effffe75
      Francois-Rene Rideau authored
      Our method to override 'load-op with *load-system-operation*
      in defmethod component-depends-on ((o prepare-op) (s system))
      was failing to call-next-method, which cancelled the
      :in-order-to in asdf.asd's own defsystem asdf. Oops.
      
      Issue: this means that ASDF 3.1.2 is unfit to bootstrap further
      variants of ASDF, and they must be bootstrapped with make,
      or their asdf.asd must be modified in a yet-to-be-determined way
      to compensate for that bug.
      effffe75
  21. 11 May, 2014 1 commit
  22. 24 Mar, 2014 2 commits
  23. 20 Mar, 2014 1 commit
    • Francois-Rene Rideau's avatar
      Fold *systems-being-defined* into the *asdf-cache*. · 84e17ea0
      Francois-Rene Rideau authored
      Add regression test for no infinite loop
      when processing asd files that mutually define each other's systems.
      (Prompted by Robert Strandh inquiring about the bug fixed in 2.015.[23]
      after my mentioning an infinite loop in my ASDF3 article.)
      Checked that removing the set-asdf-cache-entry in parse-defsystem triggers the bug.
      84e17ea0