Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
C
cl-site
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 16
    • Issues 16
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Incidents
    • Environments
  • Analytics
    • Analytics
    • CI / CD
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • clo
  • cl-site
  • Merge Requests
  • !73

Merged
Opened Oct 27, 2018 by Erik Huelsmann@ehuelsmannOwner

Refactor 'preprocess-*' and 'generate-news' into around-like functions

  • Overview 6
  • Commits 25
  • Pipelines 2
  • Changes 8

All preprocess-* functions are now called "around" the original renderer, instead of in separate passes. This approach facilitates passing information between each of the processing steps. The major driver for this change is the need to pass around the original file name, which we need to generate the Edit this page button.

Introduce a way to declare dependencies between pages. That way, we can convert generate-news into a post-processor for news.md, delaying the rendering of index.html until news.md has been generated.

And last but not least: actually add the 'Edit this page' button with a link to our GitLab project!

@dcooper, @mmontone, @vdardel, @tplotnikov: your reviews are highly appreciated! This is quite a big change and I think it's good that we agree on this path forward.

Closes #8 (closed).

Assignee
Assign to
Reviewer
Request review from
None
Milestone
None
Assign milestone
Time tracking
Reference: clo/cl-site!73
Source branch: edit-page

Revert this merge request

This will create a new commit in order to revert the existing changes.

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.

Cherry-pick this merge request

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.