Commit f51f7f0d authored by rtoy's avatar rtoy
Browse files

Cosmetic change: add vertical bars (or spaces) to separate octets when

printing out instructions.  Makes it easier to interpret bit patterns
for instructions.
parent a1c456cc
...@@ -5,7 +5,7 @@ ...@@ -5,7 +5,7 @@
;;; Carnegie Mellon University, and has been placed in the public domain. ;;; Carnegie Mellon University, and has been placed in the public domain.
;;; ;;;
(ext:file-comment (ext:file-comment
"$Header: /Volumes/share2/src/cmucl/cvs2git/cvsroot/src/compiler/disassem.lisp,v 1.54 2008/04/22 20:14:54 rtoy Exp $") "$Header: /Volumes/share2/src/cmucl/cvs2git/cvsroot/src/compiler/disassem.lisp,v 1.55 2008/10/03 14:04:22 rtoy Rel $")
;;; ;;;
;;; ********************************************************************** ;;; **********************************************************************
;;; ;;;
...@@ -1815,7 +1815,13 @@ ...@@ -1815,7 +1815,13 @@
(write-char (cond ((logbitp bit mask) (write-char (cond ((logbitp bit mask)
(if (logbitp bit num) #\1 #\0)) (if (logbitp bit num) #\1 #\0))
((< bit show) #\x) ((< bit show) #\x)
(t #\space))))) (t #\space)))
(when (and (zerop (mod bit 8))
(/= bit 0))
;; Print a vertical bar separating octets to make reading
;; easier. But use a space if we haven't shown anything yet.
;; (Preserves spacing.)
(write-char (if (< bit show) #\| #\space)))))
(defun print-inst-bits (inst) (defun print-inst-bits (inst)
(print-masked-binary (inst-id inst) (print-masked-binary (inst-id inst)
...@@ -1828,12 +1834,12 @@ ...@@ -1828,12 +1834,12 @@
(etypecase inst-space (etypecase inst-space
(null) (null)
(instruction (instruction
(format t "~vt[~a(~a)~45t" indent (format t "~vt[~a(~a)~48t" indent
(inst-name inst-space) (inst-name inst-space)
(inst-format-name inst-space)) (inst-format-name inst-space))
(print-inst-bits inst-space) (print-inst-bits inst-space)
(dolist (inst (inst-specializers inst-space)) (dolist (inst (inst-specializers inst-space))
(format t "~%~vt:~a~45t" indent (inst-name inst)) (format t "~%~vt:~a~48t" indent (inst-name inst))
(print-inst-bits inst)) (print-inst-bits inst))
(write-char #\]) (write-char #\])
(terpri)) (terpri))
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment