From 63d1896f5c0d28371d9a7356d0556fe01120f637 Mon Sep 17 00:00:00 2001 From: Raymond Toy <toy.raymond@gmail.com> Date: Sat, 23 May 2015 11:47:18 -0700 Subject: [PATCH] Fix warnings about destructive functions discarding their results (sort an delete) --- src/hemlock/bit-screen.lisp | 9 +++++---- src/hemlock/eval-server.lisp | 2 +- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/src/hemlock/bit-screen.lisp b/src/hemlock/bit-screen.lisp index 3674b246f..e95c088db 100644 --- a/src/hemlock/bit-screen.lisp +++ b/src/hemlock/bit-screen.lisp @@ -1581,10 +1581,11 @@ ;; Probably shoulds insertion sort them, but I'm lame. ;; (xlib:with-state (xparent) - (sort affected-windows #'< - :key #'(lambda (window) - (xlib:drawable-y - (bitmap-hunk-xwindow (window-hunk window)))))) + (setf affected-windows + (sort affected-windows #'< + :key #'(lambda (window) + (xlib:drawable-y + (bitmap-hunk-xwindow (window-hunk window))))))) (let ((start 0)) (declare (fixnum start)) (do ((windows affected-windows (cdr windows))) diff --git a/src/hemlock/eval-server.lisp b/src/hemlock/eval-server.lisp index b9645daba..8a1450a81 100644 --- a/src/hemlock/eval-server.lisp +++ b/src/hemlock/eval-server.lisp @@ -223,7 +223,7 @@ (find-if-not #'null array :from-end t :end current))))) - (delete nil array) + (setf array (delete nil array)) (setf (server-info-error-index server) (position current array)))) -- GitLab