From 3507e3556dbc0715f3068aaf1793f3da6d19b0b7 Mon Sep 17 00:00:00 2001 From: Francois-Rene Rideau <tunes@google.com> Date: Thu, 20 Feb 2014 21:29:52 -0500 Subject: [PATCH] Trivial non-functional cleanups (improved comments, whitespace, remove doubly exported symbols). --- component.lisp | 8 +++----- parse-defsystem.lisp | 2 +- system.lisp | 3 +-- test/script-support.lisp | 3 +-- test/test-utilities.script | 2 +- 5 files changed, 7 insertions(+), 11 deletions(-) diff --git a/component.lisp b/component.lisp index 854b63dd..ac1c206d 100644 --- a/component.lisp +++ b/component.lisp @@ -34,11 +34,9 @@ ;; Internals we'd like to share with the ASDF package, especially for upgrade purposes #:name #:version #:description #:long-description #:author #:maintainer #:licence - #:components-by-name #:components - #:children #:children-by-name #:default-component-class - #:author #:maintainer #:licence #:source-file - ;; the following retained for backward compatibility. - #:defsystem-depends-on + #:components-by-name #:components #:children #:children-by-name + #:default-component-class #:source-file + #:defsystem-depends-on ; This symbol retained for backward compatibility. #:sideway-dependencies #:if-feature #:in-order-to #:inline-methods #:relative-pathname #:absolute-pathname #:operation-times #:around-compile #:%encoding #:properties #:component-properties #:parent)) diff --git a/parse-defsystem.lisp b/parse-defsystem.lisp index 40306715..80c11415 100644 --- a/parse-defsystem.lisp +++ b/parse-defsystem.lisp @@ -170,8 +170,8 @@ (apply 'reinitialize-instance component args) (setf component (apply 'make-instance class args))) (component-pathname component) ; eagerly compute the absolute pathname - ;; cache information for introspection (when (typep component 'system) + ;; cache information for introspection (setf (slot-value component 'depends-on) depends-on (slot-value component 'weakly-depends-on) weakly-depends-on)) (let ((sysfile (system-source-file (component-system component)))) ;; requires the previous diff --git a/system.lisp b/system.lisp index 9e46bca1..4cd73541 100644 --- a/system.lisp +++ b/system.lisp @@ -66,8 +66,7 @@ :initform nil) ;; these two are specially set in parse-component-form, so have no :INITARGs. (depends-on :reader system-depends-on :initform nil) - (weakly-depends-on :reader system-weakly-depends-on :initform nil) - )) + (weakly-depends-on :reader system-weakly-depends-on :initform nil))) (defun reset-system (system &rest keys &key &allow-other-keys) (change-class (change-class system 'proto-system) 'system) diff --git a/test/script-support.lisp b/test/script-support.lisp index c798af6c..45b94a3a 100644 --- a/test/script-support.lisp +++ b/test/script-support.lisp @@ -345,8 +345,7 @@ is bound, write a message and exit on an error. If (funcall thunk)) #+allegro (excl:without-redefinition-warnings - (funcall thunk)) - ) + (funcall thunk))) (defun interactive-test (&optional files) (verbose t nil) diff --git a/test/test-utilities.script b/test/test-utilities.script index 38415b9f..4b01d4c3 100644 --- a/test/test-utilities.script +++ b/test/test-utilities.script @@ -95,7 +95,7 @@ asdf/component:default-component-class ;; the following is here only for backward compatibility; should be in ;; asdf/system. [2014/02/20:rpg] - asdf/component:defsystem-depends-on + asdf/component:defsystem-depends-on asdf/component:description asdf/component:%encoding asdf/component:if-feature -- GitLab