From 36e63221f230c21380a6b4a077649a9a5862a968 Mon Sep 17 00:00:00 2001 From: Francois-Rene Rideau <fare@tunes.org> Date: Wed, 6 Apr 2016 21:40:47 -0400 Subject: [PATCH] Canonicalize system names to strings in asdf.asd ASDF has been canonicalizing system names to string with COERCE-NAME since its very beginning. Working at Google, which uses automatic formatters to keep all its source code as canonical as possible, convinced me that keeping things canonical is better. I've been applying this style to my own systems and recommending it to others. stassats noticed that asdf.asd was failing to lead by example -- so I'm fixing it accordingly. --- asdf.asd | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/asdf.asd b/asdf.asd index f117c3f7..9deedee0 100644 --- a/asdf.asd +++ b/asdf.asd @@ -10,7 +10,7 @@ (in-package :asdf) #+asdf3 -(defsystem :asdf/prelude +(defsystem "asdf/prelude" ;; Note that it's polite to sort the defsystem forms in dependency order, ;; and compulsory to sort them in defsystem-depends-on order. :version (:read-file-form "version.lisp-expr") @@ -20,11 +20,11 @@ ((:file "header"))) #+asdf3 -(defsystem :asdf/driver - :depends-on (:uiop)) +(defsystem "asdf/driver" + :depends-on ("uiop")) #+asdf3 -(defsystem :asdf/defsystem +(defsystem "asdf/defsystem" :licence "MIT" :description "The defsystem part of ASDF" :long-name "Another System Definition Facility" @@ -40,7 +40,7 @@ :build-operation monolithic-concatenate-source-op :build-pathname "build/asdf" ;; our target :around-compile call-without-redefinition-warnings ;; we need be the same as uiop - :depends-on (:asdf/prelude :asdf/driver) + :depends-on ("asdf/prelude" "uiop") :encoding :utf-8 :components ((:file "upgrade") @@ -69,7 +69,7 @@ (:file "user" :depends-on ("interface")) (:file "footer" :depends-on ("user")))) -(defsystem :asdf +(defsystem "asdf" :author ("Daniel Barlow") :maintainer ("Robert Goldman") :licence "MIT" @@ -84,5 +84,5 @@ ;; specify separate dependencies on uiop (aka asdf-driver) and asdf/defsystem. #+asdf3 :builtin-system-p #+asdf3 t :components ((:module "build" :components ((:file "asdf")))) - :in-order-to (#+asdf3 (prepare-op (monolithic-concatenate-source-op :asdf/defsystem)))) + :in-order-to (#+asdf3 (prepare-op (monolithic-concatenate-source-op "asdf/defsystem")))) -- GitLab