## wrong keyword arguments to surf::make-transformed-brep

*Created by: avodonosov*

In the file surf/source/transformed-solid.lisp there is a call

```
(make-transformed-brep *geometry-kernel* (the brep)
:translation (the transform-vector)
:x-vector (the coordinate-base (face-normal-vector :right))
:y-vector (the coordinate-base (face-normal-vector :rear))
:sew-and-orient? (the sew-and-orient?)
:shrink? (the shrink?)
:scale-vector (the scale))
```

But the definition in the surf/solid/methods.lisp does not have keywords `:shrink?`

and `:sew-and-orient?`

```
(defmethod make-transformed-brep ((geometry-kernel vanilla-geometry-kernel) brep &key translation x-vector y-vector scale-vector)
...
```

I don't know how critical it is. Noticed this when CCL generated a compile time warning, and then failed to print the warning due to a bug in CCL (http://trac.clozure.com/ccl/ticket/1134)

**Imported comments:**

*By genworks on 2013-12-16 16:11:42 UTC*

Thanks for the catch. That doesn't throw errors in production because that function gets shadowed by one in the :smlib package, for the specific use with SMLib modeling kernel.

The ones defined in :surf package are essentially prototypes.

Anyway I got it cleaned up now.

On Mon, Dec 16, 2013 at 2:52 AM, Anton Vodonosov notifications@github.comwrote:

In the file surf/source/transformed-solid.lisp there is a call

(make-transformed-brep

geometry-kernel(the brep) :translation (the transform-vector) :x-vector (the coordinate-base (face-normal-vector :right)) :y-vector (the coordinate-base (face-normal-vector :rear)) :sew-and-orient? (the sew-and-orient?) :shrink? (the shrink?) :scale-vector (the scale))But the definition in the surf/solid/methods.lisp does not have keywords :shrink? and :sew-and-orient?

(defmethod make-transformed-brep ((geometry-kernel vanilla-geometry-kernel) brep &key translation x-vector y-vector scale-vector)...

I don't know how critical it is. Noticed this when CCL generated a compile time warning, and then failed to print the warning due to a bug in CCL ( http://trac.clozure.com/ccl/ticket/1134)

— Reply to this email directly or view it on GitHubhttps://github.com/genworks/gendl/issues/159 .

-- My Best,

Dave Cooper, Genworks Support david.cooper@genworks.com, dave.genworks.com(skype) USA: 248-327-3253(o), 1-248-330-2979(mobile) UK: 0191 645 1699