From 1ebb82a1b4bada7bebe06b734a7ad0b0297fe570 Mon Sep 17 00:00:00 2001
From: Francois-Rene Rideau <tunes@google.com>
Date: Fri, 3 Jan 2014 15:02:57 -0500
Subject: [PATCH] Refactor Makefile test targets.

---
 Makefile | 39 +++++++++++++++++++--------------------
 1 file changed, 19 insertions(+), 20 deletions(-)

diff --git a/Makefile b/Makefile
index e01e76bd..18e6c3b3 100644
--- a/Makefile
+++ b/Makefile
@@ -134,32 +134,31 @@ test: test-lisp test-clean-load test-load-systems doc
 test-load-systems: build/asdf.lisp
 	./test/run-tests.sh -l ${l} ${s}
 
-test-all-lisps:
-	${MAKE} test-load-systems
-	@for lisp in ${lisps} ; do \
-		${MAKE} test-clean-load test-lisp test-upgrade l=$$lisp || exit 1 ; \
-	done
+test-all-lisps: test-load-systems test-all-clean-load test-all-lisp test-all-upgrade
 
-# test upgrade is a very long run... This does just the regression tests
-test-all-no-upgrade:
-	@for lisp in ${lisps} ; do \
-		${MAKE} test-clean-load test-lisp l=$$lisp || exit 1 ; \
-	done
+test-all-clean-load:
+	@for lisp in ${lisps} ; do ${MAKE} test-clean-load l=$$lisp || exit 1 ; done
+
+test-all-lisp:
+	@for lisp in ${lisps} ; do ${MAKE} test-lisp l=$$lisp || exit 1 ; done
 
 test-all-upgrade:
-	@for lisp in ${lisps} ; do \
-		${MAKE} test-upgrade l=$$lisp || exit 1 ; \
-	done
+	@for lisp in ${lisps} ; do ${MAKE} test-upgrade l=$$lisp || exit 1 ; done
+
+test-all-no-upgrade: doc test-load-systems test-all-clean-load test-all-lisp
+
+test-all: test-all-no-upgrade test-all-upgrade
+
+test-all-lisp-no-stop:
+	@for lisp in ${lisps} ; do ${MAKE} test-lisp l=$$lisp ; done ; :
+
+test-all-upgrade-no-stop:
+	@for lisp in ${lisps} ; do ${MAKE} test-upgrade l=$$lisp ; done ; :
 
-test-all: doc test-all-lisps
+test-all-no-upgrade-no-stop: doc test-load-systems test-all-clean-load test-all-lisp-no-stop
 
-test-all-no-stop:
-	-make doc ; for l in ${lisps} ; do \
-	   make test-clean-load test-lisp l=$$l ; make test-upgrade l=$$l ; \
-	done ; true
+test-all-no-stop: test-all-no-upgrade-no-stop test-all-upgrade-no-stop
 
-test-all-no-upgrade-no-stop:
-	-make doc ; for l in ${lisps} ; do make test-clean-load test-lisp l=$$l ; done ; true
 
 extract: extract-all-tagged-asdf
 extract-all-tagged-asdf: build/asdf.lisp
-- 
GitLab