Commit 54c556e9 authored by Christophe Rhodes's avatar Christophe Rhodes
Browse files

A bit more robustness in the FILE-WRITE-DATE department. This version 

is still subject to filesystem races (say, between probe-file and
file-write-date) but they're a lot less likely.  Attempt to do the
"right" thing if an input file has gone missing.
parent fb9cf03b

asdf.lisp

+36 −22
Original line number Diff line number Diff line 
;;; This is asdf: Another System Definition Facility.  $Revision: 1.94 $

;;; This is asdf: Another System Definition Facility.  $Revision: 1.95 $

;;;

;;; Feedback, bug reports, and patches are all welcome: please mail to

;;; <cclan-list@lists.sf.net>.  But note first that the canonical
@@ -109,7 +109,7 @@ 


(in-package #:asdf)



(defvar *asdf-revision* (let* ((v "$Revision: 1.94 $")

(defvar *asdf-revision* (let* ((v "$Revision: 1.95 $")

			       (colon (or (position #\: v) -1))

			       (dot (position #\. v)))

			  (and v colon dot
@@ -583,6 +583,20 @@ system.")) 
(defmethod input-files ((operation operation) (c module)) nil)



(defmethod operation-done-p ((o operation) (c component))

  (flet ((fwd-or-return-t (file)

           ;; if FILE-WRITE-DATE returns NIL, it's possible that the

           ;; user or some other agent has deleted an input file.  If

           ;; that's the case, well, that's not good, but as long as

           ;; the operation is otherwise considered to be done we

           ;; could continue and survive.

           (let ((date (file-write-date file)))

             (cond

               (date)

               (t 

                (warn "~@<Missing FILE-WRITE-DATE for ~S: treating ~

                       operation ~S on component ~S as done.~@:>" 

                      file o c)

                (return-from operation-done-p t))))))

    (let ((out-files (output-files o c))

          (in-files (input-files o c)))

      (cond ((and (not in-files) (not out-files))
@@ -595,14 +609,14 @@ system.")) 
                             (component-operation-times c))))

               (and op-done

                    (>= op-done

		      (or (apply #'max

				 (mapcar #'file-write-date in-files)) 0)))))

                        (apply #'max

                               (mapcar #'fwd-or-return-t in-files))))))

            ((not in-files) nil)

            (t

             (and

              (every #'probe-file out-files)

              (> (apply #'min (mapcar #'file-write-date out-files))

	       (apply #'max (mapcar #'file-write-date in-files)) ))))))

                 (apply #'max (mapcar #'fwd-or-return-t in-files)))))))))



;;; So you look at this code and think "why isn't it a bunch of

;;; methods".  And the answer is, because standard method combination