Loading 95TODO +34 −0 Original line number Diff line number Diff line Loading @@ -75,3 +75,37 @@ TODO for cl-launch as of 4.1.4 and a series of (declaim (optimize (speed 0) (size 0) (debug 0) (compilation-speed 3))) and such to speed up the cl-launch bootstrap? * Fix debian packaging. ** Report by Tobias Frost <tobi@debian.org> I see that your package has several DDs a uploaders. I'm wondering why they don't upload it for you, if they co-maintain the package? Did you file an RFS-Bug? In d/changelog, there are many versions that where never in Debian, also it reads more like an upstream changelog than an Debian changelog. On the other side, changes to debian/* are not explained. (e.g the fact and the resons why to update all the versions of the dependencies in d/control). Refer to the Policy about d/changelog. d/cl-launch.1 The manpage says "generated with Ronn/v0.7.3". If it is autogenerated, it needs to be done at build time. d/control About your layout: It is not recommended to have the debian directory in your master branch, as you cannot independently work on those. Think of NMUs and how you would be able to integrate such changes in your repository? (I suggest to put the debian packaging into its own branch.) This is also the point where I point people to https://wiki.debian.org/UpstreamGuide, if they are upstream and maintainer at the same time. d/rules could be transformed to short debhelper format. (note: did not check alls details in d/copyright, so just a few things I saw at first glance) d/copyright: - The bugroff license text is missing. - Copyright years are not up to date Makefile +12 −12 Original line number Diff line number Diff line Loading @@ -14,7 +14,7 @@ all: source source: @echo "Building Lisp source code for cl-launch in current directory" @${CL_LAUNCH} --include ${PWD} -B install_path > /dev/null @${CL_LAUNCH} --include "$${PWD}" -B install_path > /dev/null install: install_binary install_source install_system install_cl Loading @@ -22,26 +22,26 @@ install_binary: install_binary_standalone install_source: @echo "Installing Lisp source code for cl-launch in ${INSTALL_SOURCE}" @mkdir -p ${INSTALL_SOURCE}/ @${CL_LAUNCH} --include ${INSTALL_SOURCE} -B install_path > /dev/null @if [ ! $${PWD} = ${INSTALL_SOURCE} ] ; then \ @cp dispatch.lisp ${INSTALL_SOURCE}/ ; \ @mkdir -p "${INSTALL_SOURCE}/" @${CL_LAUNCH} --include "${INSTALL_SOURCE}" -B install_path > /dev/null @if [ ! "$${PWD}" = "${INSTALL_SOURCE}" ] ; then \ @cp dispatch.lisp "${INSTALL_SOURCE}/" ; \ fi install_system: install_source @echo "Linking .asd file for cl-launch into ${INSTALL_SYSTEMS}/" @mkdir -p ${INSTALL_SYSTEMS}/ @if [ `dirname ${INSTALL_SYSTEMS}`/source/cl-launch = ${INSTALL_SOURCE} ] ; then \ ln -sf ../source/cl-launch/cl-launch.asd ${INSTALL_SYSTEMS}/ ; \ @mkdir -p "${INSTALL_SYSTEMS}/" @if [ "`dirname '${INSTALL_SYSTEMS}'`/source/cl-launch" = "${INSTALL_SOURCE}" ] ; then \ ln -sf ../source/cl-launch/cl-launch.asd "${INSTALL_SYSTEMS}/" ; \ else \ ln -sf ${INSTALL_SOURCE}/cl-launch.asd ${INSTALL_SYSTEMS}/ ; \ ln -sf "${INSTALL_SOURCE}/cl-launch.asd" "${INSTALL_SYSTEMS}/" ; \ fi install_binary_standalone: @echo "Installing a standalone binary of cl-launch in ${INSTALL_BIN}/" @sh ./cl-launch.sh --no-include --no-rc \ --lisp '$(LISPS)' \ --output ${INSTALL_BIN}/cl-launch -B install_bin > /dev/null --output '${INSTALL_BIN}/cl-launch' -B install_bin > /dev/null install-with-include: install_binary_with_include install_source install_system Loading Loading @@ -79,9 +79,9 @@ reinstall: # This might fit your system, installing from same directory reinstall_here: -git clean -xfd make install_source install_binary_standalone INSTALL_SOURCE=$$PWD INSTALL_BIN=$$PWD make install_source install_binary_standalone INSTALL_SOURCE="$${PWD}" INSTALL_BIN="$${PWD}" test: tests: ./cl-launch.sh -l "${LISPS}" -B tests WRONGFUL_TAGS := RELEASE upstream Loading debian/cl-launch.dirs 0 → 100644 +4 −0 Original line number Diff line number Diff line usr/bin usr/share/common-lisp/source/cl-launch usr/share/doc/cl-launch usr/share/man/man1 debian/cl-launch.install 0 → 100644 +2 −0 Original line number Diff line number Diff line launcher.lisp wrapper.sh cl-launch.asd build.xcvb dispatch.lisp usr/share/common-lisp/source/cl-launch/ cl-launch usr/bin debian/cl-launch.manpages 0 → 100644 +1 −0 Original line number Diff line number Diff line debian/cl-launch.1 Loading
95TODO +34 −0 Original line number Diff line number Diff line Loading @@ -75,3 +75,37 @@ TODO for cl-launch as of 4.1.4 and a series of (declaim (optimize (speed 0) (size 0) (debug 0) (compilation-speed 3))) and such to speed up the cl-launch bootstrap? * Fix debian packaging. ** Report by Tobias Frost <tobi@debian.org> I see that your package has several DDs a uploaders. I'm wondering why they don't upload it for you, if they co-maintain the package? Did you file an RFS-Bug? In d/changelog, there are many versions that where never in Debian, also it reads more like an upstream changelog than an Debian changelog. On the other side, changes to debian/* are not explained. (e.g the fact and the resons why to update all the versions of the dependencies in d/control). Refer to the Policy about d/changelog. d/cl-launch.1 The manpage says "generated with Ronn/v0.7.3". If it is autogenerated, it needs to be done at build time. d/control About your layout: It is not recommended to have the debian directory in your master branch, as you cannot independently work on those. Think of NMUs and how you would be able to integrate such changes in your repository? (I suggest to put the debian packaging into its own branch.) This is also the point where I point people to https://wiki.debian.org/UpstreamGuide, if they are upstream and maintainer at the same time. d/rules could be transformed to short debhelper format. (note: did not check alls details in d/copyright, so just a few things I saw at first glance) d/copyright: - The bugroff license text is missing. - Copyright years are not up to date
Makefile +12 −12 Original line number Diff line number Diff line Loading @@ -14,7 +14,7 @@ all: source source: @echo "Building Lisp source code for cl-launch in current directory" @${CL_LAUNCH} --include ${PWD} -B install_path > /dev/null @${CL_LAUNCH} --include "$${PWD}" -B install_path > /dev/null install: install_binary install_source install_system install_cl Loading @@ -22,26 +22,26 @@ install_binary: install_binary_standalone install_source: @echo "Installing Lisp source code for cl-launch in ${INSTALL_SOURCE}" @mkdir -p ${INSTALL_SOURCE}/ @${CL_LAUNCH} --include ${INSTALL_SOURCE} -B install_path > /dev/null @if [ ! $${PWD} = ${INSTALL_SOURCE} ] ; then \ @cp dispatch.lisp ${INSTALL_SOURCE}/ ; \ @mkdir -p "${INSTALL_SOURCE}/" @${CL_LAUNCH} --include "${INSTALL_SOURCE}" -B install_path > /dev/null @if [ ! "$${PWD}" = "${INSTALL_SOURCE}" ] ; then \ @cp dispatch.lisp "${INSTALL_SOURCE}/" ; \ fi install_system: install_source @echo "Linking .asd file for cl-launch into ${INSTALL_SYSTEMS}/" @mkdir -p ${INSTALL_SYSTEMS}/ @if [ `dirname ${INSTALL_SYSTEMS}`/source/cl-launch = ${INSTALL_SOURCE} ] ; then \ ln -sf ../source/cl-launch/cl-launch.asd ${INSTALL_SYSTEMS}/ ; \ @mkdir -p "${INSTALL_SYSTEMS}/" @if [ "`dirname '${INSTALL_SYSTEMS}'`/source/cl-launch" = "${INSTALL_SOURCE}" ] ; then \ ln -sf ../source/cl-launch/cl-launch.asd "${INSTALL_SYSTEMS}/" ; \ else \ ln -sf ${INSTALL_SOURCE}/cl-launch.asd ${INSTALL_SYSTEMS}/ ; \ ln -sf "${INSTALL_SOURCE}/cl-launch.asd" "${INSTALL_SYSTEMS}/" ; \ fi install_binary_standalone: @echo "Installing a standalone binary of cl-launch in ${INSTALL_BIN}/" @sh ./cl-launch.sh --no-include --no-rc \ --lisp '$(LISPS)' \ --output ${INSTALL_BIN}/cl-launch -B install_bin > /dev/null --output '${INSTALL_BIN}/cl-launch' -B install_bin > /dev/null install-with-include: install_binary_with_include install_source install_system Loading Loading @@ -79,9 +79,9 @@ reinstall: # This might fit your system, installing from same directory reinstall_here: -git clean -xfd make install_source install_binary_standalone INSTALL_SOURCE=$$PWD INSTALL_BIN=$$PWD make install_source install_binary_standalone INSTALL_SOURCE="$${PWD}" INSTALL_BIN="$${PWD}" test: tests: ./cl-launch.sh -l "${LISPS}" -B tests WRONGFUL_TAGS := RELEASE upstream Loading
debian/cl-launch.dirs 0 → 100644 +4 −0 Original line number Diff line number Diff line usr/bin usr/share/common-lisp/source/cl-launch usr/share/doc/cl-launch usr/share/man/man1
debian/cl-launch.install 0 → 100644 +2 −0 Original line number Diff line number Diff line launcher.lisp wrapper.sh cl-launch.asd build.xcvb dispatch.lisp usr/share/common-lisp/source/cl-launch/ cl-launch usr/bin
debian/cl-launch.manpages 0 → 100644 +1 −0 Original line number Diff line number Diff line debian/cl-launch.1