• mevenson@1c010e3e-69d0-11dd-93a8-456734b0d56f's avatar
    Standardize use CL:*LOAD-VERBOSE* to control loading verbosity · 5992ced7
    Normalize logging output to a Lisp comment prefix (#\;) with a single tag
    that identifies the "subsystem" emitting the diagnostic.
    
    ABCL-ASDF:*MAVEN-VERBOSE* SYS:*ABCL-CONTRIB-VERBOSE* have been removed; use
    CL:*LOAD-VERBOSE* to control them.
    
    ASDF::*VERBOSE-OUT* and QUICKLISP-CLIENT::*QUICKLOAD-VERBOSE* cannot
    be easily modified while keeping in-sync with upstream, but they both
    seem to respect setting CL:*LOAD-VERBOSE* to nil to muffle output.
    
    EXT::*WARN-ON-REDEFINITION* signals conditions rather than just
    emitting error messages, so it has not been touched as theoretically
    some compiler tooling may be somehow be depending on its SIGNAL
    behavior.  As such, once an implementation that signals the same
    warnings as EXT::*WARN-ON-REDEFINITION* based on CL:*COMPILE-VERBOSE*
    setting should be maintained during a deprecation phase.
    
    ------------------------------------------------------------------------
    # From <https://github.com/armedbear/abcl/commit/6cc94a54cf9256b2a0f13857d4c448d3b5c044fc>
    
    ## Alan Ruttenberg
    
    Really this should just respect load-verbose. If you really want to
    fix this properly, do that. There are a proliferation of settings one
    has to know about if one wants ABCL to shut up while starting up, and
    any beginner will have a hell of a time accomplishing this. There
    ought to be a single variable that indicates you don't want these
    messages.
    
    - *load-verbose*
    - system::*verbose*
    - asdf::*verbose-out*
    - abcl-asdf::*maven-verbose
    - quicklisp-client::*quickload-verbose*
    - ext::*warn-on-redefinition*
    
    ## Mark Evenson
    
    Using CL:LOAD-VERBOSE to unify the control of all this logging
    behavior for ABCL is an excellent way forward here.
    
    This wouldn't help with quicklisp-client::quickload-verbose (not our code).
    
    An alternative would be to have some sort of "categorical logging
    system" (ala log4j) which would allow one to selectively enable
    classes of logging output ("show me all diagnostic from loading
    ABCL-CONTRIB"), but a basic boolean predicate here, unified into the
    standardized mechanism would go a long ways.
    
    ------------------------------------------------------------------------
    
    Originated with <https://github.com/armedbear/abcl/pull/37>.
    5992ced7