Skip to content
Snippets Groups Projects
Commit 36ca4387 authored by Jacek Złydach's avatar Jacek Złydach
Browse files

Changed defaults on the workaround parameter in scrollbar handlers.

From NIL to 0.0, the param should be numeric if used at all.

+ added notes on my confusion about the magic that happens in
code of #'unhighlight-highlighted-presentation.
parent 49606b18
No related branches found
No related tags found
No related merge requests found
...@@ -472,10 +472,14 @@ ...@@ -472,10 +472,14 @@
(let ((history-window (if prefer-pointer-window (find-appropriate-window stream) stream))) (let ((history-window (if prefer-pointer-window (find-appropriate-window stream) stream)))
(when history-window (when history-window
(with-slots (highlighted-presentation) history-window (with-slots (highlighted-presentation) history-window
;; FIXME this when seems to be magic.
;; Somehow control passes into it (highlighted-presentation must be not NIL), but during call to
;; #'highlight-presentation (and earlier, to #'presentation-type, highlighted-presentation is exactly NIL.
;; -- jacek.zlydach 2017-06-03
(when highlighted-presentation (when highlighted-presentation
(highlight-presentation (highlight-presentation
highlighted-presentation (presentation-type highlighted-presentation) highlighted-presentation (presentation-type highlighted-presentation)
history-window :unhighlight) history-window :unhighlight)
(setf highlighted-presentation nil)))))) (setf highlighted-presentation nil))))))
(defun find-appropriate-window (stream) (defun find-appropriate-window (stream)
......
...@@ -595,21 +595,21 @@ ...@@ -595,21 +595,21 @@
(#.+pointer-left-button+ (#.+pointer-left-button+
(ecase (slot-value pane 'end) (ecase (slot-value pane 'end)
(:greater-than (:greater-than
(scroll-down-page-callback scroll-bar client id nil)) ;NOTE WORKAROUND added last param = nil -- jacek.zlydach, 2017-06-03 (scroll-down-page-callback scroll-bar client id 0.0)) ;NOTE WORKAROUND added last param = 0.0 -- jacek.zlydach, 2017-06-03
(:less-than (:less-than
(scroll-down-line-callback scroll-bar client id nil)))) ;NOTE WORKAROUND added last param = nil -- jacek.zlydach, 2017-06-03 (scroll-down-line-callback scroll-bar client id 0.0)))) ;NOTE WORKAROUND added last param = 0.0 -- jacek.zlydach, 2017-06-03
(#.+pointer-middle-button+ (#.+pointer-middle-button+
(ecase (slot-value pane 'end) (ecase (slot-value pane 'end)
(:greater-than (:greater-than
(scroll-to-bottom-callback scroll-bar client id nil)) ;NOTE WORKAROUND added last param = nil -- jacek.zlydach, 2017-06-03 (scroll-to-bottom-callback scroll-bar client id 0.0)) ;NOTE WORKAROUND added last param = 0.0 -- jacek.zlydach, 2017-06-03
(:less-than (:less-than
(scroll-to-top-callback scroll-bar client id nil)))) ;NOTE WORKAROUND added last param = nil -- jacek.zlydach, 2017-06-03 (scroll-to-top-callback scroll-bar client id 0.0)))) ;NOTE WORKAROUND added last param = 0.0 -- jacek.zlydach, 2017-06-03
(#.+pointer-right-button+ (#.+pointer-right-button+
(ecase (slot-value pane 'end) (ecase (slot-value pane 'end)
(:greater-than (:greater-than
(scroll-up-page-callback scroll-bar client id nil)) ;NOTE WORKAROUND added last param = nil -- jacek.zlydach, 2017-06-03 (scroll-up-page-callback scroll-bar client id 0.0)) ;NOTE WORKAROUND added last param = 0.0 -- jacek.zlydach, 2017-06-03
(:less-than (:less-than
(scroll-up-line-callback scroll-bar client id nil))))))) ;NOTE WORKAROUND added last param = nil -- jacek.zlydach, 2017-06-03 (scroll-up-line-callback scroll-bar client id 0.0))))))) ;NOTE WORKAROUND added last param = 0.0 -- jacek.zlydach, 2017-06-03
(defmethod handle-event ((pane scroll-bar-shaft-pane) (defmethod handle-event ((pane scroll-bar-shaft-pane)
(event pointer-button-press-event)) (event pointer-button-press-event))
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment