Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • C cl-smtp
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 6
    • Issues 6
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 2
    • Merge requests 2
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • cl-smtp
  • cl-smtp
  • Merge requests
  • !2

Use local-hostname for HELO command

  • Review changes

  • Download
  • Patches
  • Plain diff
Open x0r requested to merge xtab/cl-smtp:master into master Feb 17, 2021
  • Overview 0
  • Commits 2
  • Pipelines 0
  • Changes 1

In the SMTP-HANDSHAKE function, a EHLO command is sent to the server if ESMTP features are required and HELO otherwise. The EHLO command was followed by the value of LOCAL-HOSTNAME, whereas HELO erroneously used the result of USOCKET::GET-HOST-NAME directly.

This leads to the HELO command being rejected, since USOCKET::GET-HOST-NAME does not return a FQDN. With this fix, and an explicit :LOCAL-HOSTNAME keyword argument given to SEND-EMAIL, e-mails go through normally.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: master