create-target.sh doesn't update setenv with the appropriate OS features.
Describe the bug
At the end of bin/create-target.sh
there's a bit of code that copies
linux-features.lisp
(or freebsd-features.lisp
) to setenv.lisp
in
the target directory. This isn't working.
To Reproduce
Steps to reproduce the behavior:
- Run
bin/create-target.sh test-target x86_linux
- Examine
test-target/setenv.lisp
- Compare this with
src/tools/setenv-scripts/linux-features.lisp
- The contents of
linux-features.lisp
aren't anywhere insetenv.lisp
.
Expected behavior
Based on the code, the file should be copied. But note that
linux-features.lisp
doesn't really do anything except remove
:glib2.1
from *features*
.
One item to note is that create-target.sh
adds :gencgc
to
*features*
, apparently to enable gencgc. This bit is commented out,
however, so it doesn't actually add it. x86 uses gencgc by default
and has for at least decade.
Desktop (please complete the following information):
- OS: Linux, FreeBSD, Solaris
- Version:
Additional context
Not sure what to do here. Fix it so that the files are copied. This
is easily done by remove the part >> setenv.lisp
. Or just remove
this and the corresponding feature files. The latter is appealing.
It's been so long that I've had to touch these, I don't really remember what to do with them. However, this might be an easy way to re-enable cgc (see #224) instead of having to do a full cross-compile.