Skip to content
GitLab
Explore
Sign in
Register
Primary navigation
Search or go to…
Project
cmucl
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Wiki
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Package Registry
Model registry
Operate
Environments
Terraform modules
Monitor
Incidents
Service Desk
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Terms and privacy
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
Carl Shapiro
cmucl
Commits
029888fd
Commit
029888fd
authored
27 years ago
by
dtc
Browse files
Options
Downloads
Patches
Plain Diff
Fix the single value return from the function end breakpoint which had
been returning two values.
parent
5cf131a7
No related branches found
No related tags found
No related merge requests found
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
lisp/x86-assem.S
+10
-13
10 additions, 13 deletions
lisp/x86-assem.S
with
10 additions
and
13 deletions
lisp/x86-assem.S
+
10
−
13
View file @
029888fd
###
x86
-
assem.S
-*-
Mode
:
Asm
; -*-
###
x86
-
assem.S
-*-
Mode
:
Asm
; -*-
/**
/**
*
$Header
:
/
Volumes
/
share2
/
src
/
cmucl
/
cvs2git
/
cvsroot
/
src
/
lisp
/
x86
-
assem
.
S
,
v
1
.
9
199
7
/
1
1
/
2
9
19
:
52
:
32
dtc
Exp
$
*
$Header
:
/
Volumes
/
share2
/
src
/
cmucl
/
cvs2git
/
cvsroot
/
src
/
lisp
/
x86
-
assem
.
S
,
v
1
.
10
199
8
/
0
1
/
1
9
09
:
01
:
59
dtc
Exp
$
*
*
*
Authors
:
Paul
F
.
Werkowski
<
pw
@
snoopy
.
mv
.
com
>
*
Authors
:
Paul
F
.
Werkowski
<
pw
@
snoopy
.
mv
.
com
>
*
Douglas
T
.
Crosher
*
Douglas
T
.
Crosher
...
@@ -269,16 +269,14 @@ GNAME(closure_tramp):
...
@@ -269,16 +269,14 @@ GNAME(closure_tramp):
GNAME
(
function_end_breakpoint_guts
):
GNAME
(
function_end_breakpoint_guts
):
/
*
Multiple
Value
return
*/
/
*
Multiple
Value
return
*/
jmp
multiple_value_return
jmp
multiple_value_return
/
*
Single
value
return
*/
/
*
Single
value
return
:
The
eventual
return
will
now
use
the
multiple
values
return
convention
but
with
a
return
values
/
*
The
eventual
return
will
now
be
a
multi
-
value
return
so
count
of
one
.
*/
setup
for
it
.
Multi
-
value
returns
are
not
in
general
valid
movl
%
esp
,%
ebx
#
Setup
ebx
-
the
ofp
.
for
one
value
so
convert
to
2
values
.
Perhaps
the
subl
$
4
,%
esp
#
Allocate
one
stack
slot
for
the
return
value
convertion
should
be
changed
?
*/
movl
$
4
,%
ecx
#
Setup
ecx
for
one
return
value
.
movl
$
8
,%
ecx
#
Setup
ecx
=
2
for
the
debugger
.
movl
$NIL
,%
edi
#
Default
second
value
movl
$NIL
,%
edi
#
Second
value
movl
$NIL
,%
esi
#
Default
third
value
movl
%
esp
,%
ebx
#
ebx
has
the
ofp
subl
$
8
,%
esp
#
needed
?
multiple_value_return
:
multiple_value_return
:
...
@@ -286,11 +284,10 @@ multiple_value_return:
...
@@ -286,11 +284,10 @@ multiple_value_return:
GNAME
(
function_end_breakpoint_trap
):
GNAME
(
function_end_breakpoint_trap
):
int3
int3
.
byte
trap_FunctionEndBreakpoint
.
byte
trap_FunctionEndBreakpoint
hlt
#
Should
never
return
here
.
/
*
Never
returns
here
.
*/
.
global
GNAME
(
function_end_breakpoint_end
)
.
global
GNAME
(
function_end_breakpoint_end
)
GNAME
(
function_end_breakpoint_end
):
GNAME
(
function_end_breakpoint_end
):
hlt
.
global
GNAME
(
do_pending_interrupt
)
.
global
GNAME
(
do_pending_interrupt
)
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment