Skip to content
Snippets Groups Projects
Commit 2146a391 authored by rtoy's avatar rtoy
Browse files

Fix some issues with ppc callbacks.

o Save the args that are in registers before we create our stack
  frame.  We were storing the args in our own stack frame, breaking
  the connection between these args and any args that were allocated
  on the stack.  By doing this first, the register args and stack args
  are all contiguous as expected by the callback.
o Create the stack frame appropriately with enough room to store our
  callee-saved registers.
o We were not allocating enough space (4 args, not 3!) on the stack
  for funcall3 to save its args.  I don't think funcall3 needs to, but
  this is safe.
o Document the stack layout so the next person doesn't have to read
  the code to figure it out again.
parent e34f6e4e
No related branches found
No related tags found
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment