Skip to content
GitLab
Explore
Sign in
Register
Primary navigation
Search or go to…
Project
A
asdf
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Wiki
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Package registry
Container Registry
Model registry
Operate
Environments
Terraform modules
Monitor
Incidents
Service Desk
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Terms and privacy
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
Gary Palter
asdf
Commits
40816022
Commit
40816022
authored
4 years ago
by
Francois-Rene Rideau
Committed by
Robert Goldman
3 years ago
Browse files
Options
Downloads
Patches
Plain Diff
Remove unnecessary upgrades from defgeneric to defun
parent
32a579df
No related branches found
Branches containing commit
No related tags found
Tags containing commit
No related merge requests found
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
upgrade.lisp
+5
-12
5 additions, 12 deletions
upgrade.lisp
with
5 additions
and
12 deletions
upgrade.lisp
+
5
−
12
View file @
40816022
...
...
@@ -108,28 +108,21 @@ previously-loaded version of ASDF."
(
when-upgrading
()
(
let*
((
previous-version
(
first
*previous-asdf-versions*
))
(
redefined-functions
;; List of functions that changed incompatibly since 2.27:
;; gf signature changed
(should NOT happen)
, defun that became a generic function
or
;;
the other way around,
method removed that will mess up with new ones
;; gf signature changed, defun that became a generic function
(but not way around),
;; method removed that will mess up with new ones
;; (especially :around :before :after, more specific or call-next-method'ed method)
;; and/or semantics otherwise modified. Oops.
;; NB: it's too late to do anything about functions in UIOP!
;; If you introduce some critical incompatibility there, you MUST change the function name.
;; Note that we don't need do anything about functions that changed incompatibly
;; from ASDF 2.26 or earlier: we wholly punt on the entire ASDF package in such an upgrade.
;; Also, the strong constraints apply most importantly for functions called from
;; the continuation of compiling or loading some of the code in ASDF or UIOP.
;; See discussion at https://gitlab.common-lisp.net/asdf/asdf/merge_requests/36
;; and at https://gitlab.common-lisp.net/asdf/asdf/-/merge_requests/141
`
(
,@
(
when
(
version<
previous-version
"2.31"
)
'
(
#:normalize-version
))
;; pathname became &key
,@
(
when
(
version<
previous-version
"3.1.2"
)
'
(
#:component-depends-on
#:input-files
))
;; crucial methods *removed* before 3.1.2
,@
(
when
(
version<
previous-version
"3.1.7.20"
)
'
(
#:find-component
))
,@
(
when
(
version<
previous-version
"3.2.0"
)
'
(
#:required-components
))
; was a gf
,@
(
when
(
version<
previous-version
"3.3.0"
)
'
(
#:action-valid-p
#:map-direct-dependencies
;; were gfs with plan first
#:reduce-direct-dependencies
#:direct-dependencies
))
,@
(
when
(
version<
previous-version
"3.3.2.11"
)
;; were gfs
'
(
#:system-long-name
#:system-description
#:system-long-description
#:system-author
#:system-maintainer
#:system-mailto
#:system-homepage
#:system-source-control
#:system-licence
#:system-license
#:system-version
#:system-bug-tracker
))))
,@
(
when
(
version<
previous-version
"3.1.7.20"
)
'
(
#:find-component
))))
;; added &key registered
(
redefined-classes
;; redefining the classes causes interim circularities
;; with the old ASDF during upgrade, and many implementations bork
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment