Skip to content
GitLab
Explore
Sign in
Register
Primary navigation
Search or go to…
Project
A
asdf
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Wiki
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Package registry
Container registry
Model registry
Operate
Environments
Terraform modules
Monitor
Incidents
Service Desk
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Terms and privacy
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
Gary Palter
asdf
Commits
b8089dae
Commit
b8089dae
authored
4 years ago
by
Robert Goldman
Browse files
Options
Downloads
Patches
Plain Diff
Output T unsupported on ABCL.
parent
fd28c3c7
No related branches found
No related tags found
No related merge requests found
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
test/test-run-program-unix.script
+33
-18
33 additions, 18 deletions
test/test-run-program-unix.script
uiop/launch-program.lisp
+2
-2
2 additions, 2 deletions
uiop/launch-program.lisp
with
35 additions
and
20 deletions
test/test-run-program-unix.script
+
33
−
18
View file @
b8089dae
...
...
@@ -152,6 +152,12 @@
(define-condition test-failure (error)
())
(define-condition unexpected-test-success (error)
((test-designator :initarg :test-designator))
(:report (lambda (condition stream)
(format stream "On this lisp implementation expected test ~a to fail, but it succeeded."
(slot-value condition 'test-designator)))))
;;; Testing utilities
(defun file-contains-exactly (filename expected-content)
...
...
@@ -186,6 +192,29 @@
(error 'test-skipped :reason "ext:terminate-process missing"))
(apply #'terminate-process rest))
(defmacro expected-unimplemented ((impl-or-impl-list &key test-designator)
&body body)
(let* ((impl-list (if (listp impl-or-impl-list)
impl-or-impl-list
(list impl-or-impl-list)))
(non-implementing-implementation
`(some #'(lambda (x) (featurep x)) ',impl-list)))
`(when (and ,non-implementing-implementation
(eq
(catch 'unimplemented
(handler-bind
((not-implemented-error
#'(lambda (x)
(when ,non-implementing-implementation
(format t "~&This behavior is expected to be unimplemented on this lisp.~%"))
(throw 'unimplemented t))))
,@body
:implemented
))
:implemented))
(error 'unexpected-test-success :test-designator ,test-designator))))
;;; The actual tests
(new-test-suite "run-program/launch-program")
...
...
@@ -212,30 +241,16 @@
(define-test
"launch-program :output t"
(catch 'unimplemented
(handler-bind
(
#+lispworks
(not-implemented-error
#'(lambda (x)
(format t "~&This behavior is expected to be unimplemented on this lisp.~%")
(throw 'unimplemented t))))
(expected-unimplemented ((:lispworks :abcl) :test-designator "launch-program :output t")
(launch-program (list "echo" "echoing output")
:output t)))
)
:output t)))
(define-test
"launch-program :error-output t"
(catch 'unimplemented
(handler-bind
(
#+lispworks
(not-implemented-error
#'(lambda (x)
(format t "~&This behavior is expected to be unimplemented on this lisp.~%")
(throw 'unimplemented t))))
(expected-unimplemented ((:lispworks :abcl) :test-designator "launch-program :error-output t")
(uiop:wait-process
(launch-program (format nil "./exiter.sh 0 ~a" output-string)
:error-output t))))
)
:error-output t))))
(define-test
":output <file> (file e.)"
...
...
This diff is collapsed.
Click to expand it.
uiop/launch-program.lisp
+
2
−
2
View file @
b8089dae
...
...
@@ -168,11 +168,11 @@ argument to pass to the internal RUN-PROGRAM"
role
specifier
))
(
t
(
parameter-error
"~S IO specifier invalid for ~S"
specifier
role
))))
((
eql
t
)
#+
lispworks
#+
(
or
lispworks
abcl
)
(
not-implemented-error
:interactive-output
"On this lisp implementation, cannot interpret ~a value of ~a"
specifier
role
)
#-
lispworks
#-
(
or
lispworks
abcl
)
(
cond
((
eq
role
:error-output
)
*error-output*
)
((
eq
role
:output
)
#+
lispworks
*terminal-io*
#-
lispworks
*standard-output*
)
((
eq
role
:input
)
*standard-input*
)))
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment