2.26.46: only do things in-image if needed.
This restores the feature of do-first that was lost while refactoring ASDF to fix the timestamp propagation issue. The old asdf-bundle worked implicitly because of do-first: fasl-op DEPENDS-ON compile-op, and compile-op has a DO-FIRST on the load-op of dependencies, NOT a DEPENDS-ON, so if the compile-op is "done" (which did NOT check the timestamps of dependencies), then the dofirst is never consulted and load-op is never traversed. In our new ASDF, we want to always traverse the load-op of dependencies, so we can propagate their timestamps; however, we still want to only actually load them if they are needed. Therefore, visiting actions takes an additional flag "needed in this image", and each visited action can be planned or not planned yet, and a not planned yet action can be visited a second time to plan it after recursively visiting its dependencies with the "needed" flag set. Tests were fixed now to work now that this distinction exists.
Showing
- asdf.asd 1 addition, 1 deletionasdf.asd
- asdf.lisp 89 additions, 42 deletionsasdf.lisp
- test/test-missing-lisp-file.asd 2 additions, 2 deletionstest/test-missing-lisp-file.asd
- test/test-samedir-modules.asd 2 additions, 2 deletionstest/test-samedir-modules.asd
- test/test-samedir-modules.script 3 additions, 4 deletionstest/test-samedir-modules.script
- test/test1.asd 2 additions, 2 deletionstest/test1.asd
- test/test1.script 3 additions, 3 deletionstest/test1.script
- test/test2.asd 2 additions, 1 deletiontest/test2.asd
- test/test2.script 7 additions, 7 deletionstest/test2.script
- test/test2a.asd 2 additions, 5 deletionstest/test2a.asd
- test/test2b1.asd 2 additions, 1 deletiontest/test2b1.asd
- test/test2b2.asd 2 additions, 1 deletiontest/test2b2.asd
- test/test2b3.asd 2 additions, 1 deletiontest/test2b3.asd
Loading
Please register or sign in to comment